Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert metadata classes to records #21572

Merged
merged 21 commits into from
Apr 18, 2024
Merged

Convert metadata classes to records #21572

merged 21 commits into from
Apr 18, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Apr 16, 2024

No description provided.

@wendigo wendigo added the no-release-notes This pull request does not require release notes entry label Apr 16, 2024
@cla-bot cla-bot bot added the cla-signed label Apr 16, 2024
@wendigo wendigo requested a review from ebyhr April 16, 2024 12:30
@github-actions github-actions bot added tests:hive iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector mongodb MongoDB connector labels Apr 16, 2024
@ebyhr ebyhr requested a review from martint April 16, 2024 23:02
@wendigo wendigo requested a review from ebyhr April 17, 2024 07:20
@wendigo
Copy link
Contributor Author

wendigo commented Apr 17, 2024

I've dropped controversial Split changes. Other commits were mechanical in nature.

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM %

@findepi
Copy link
Member

findepi commented Apr 17, 2024

There are related test failures.
Since this PR has many commits, it's impractical to re-review.
it would be best to move out anything already marked for moving out, and also anything problematic (eg causing test failures or needing any non-mechanical changes).

@wendigo
Copy link
Contributor Author

wendigo commented Apr 17, 2024

Rebased

@wendigo wendigo merged commit 03b7e6c into master Apr 18, 2024
122 checks passed
@wendigo wendigo deleted the serafin/metadata-records branch April 18, 2024 17:25
@github-actions github-actions bot added this to the 446 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector mongodb MongoDB connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

None yet

3 participants