Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling Iceberg new table location empty check #21678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weijiii
Copy link
Member

@weijiii weijiii commented Apr 24, 2024

Description

  • Introduce a new property for Iceberg connector - iceberg.new-table-location-empty-check-enabled which determines whether Trino should check if the target table location for a new Iceberg table is empty.

Additional context and related issues

  • For both TrinoCatalog from Trino or BaseMetastoreCatalog from Iceberg, the default location API is an implementation choice up to each catalog type. Checking the location regardlessly may cause errors for some implementations. For example, a catalog type can delegate to the remote table service to assure that no location would be shared by multiple tables and not provide a default table location to the query engines.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link

cla-bot bot commented Apr 24, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jing-Wei Lu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the iceberg Iceberg connector label Apr 24, 2024
@weijiii weijiii force-pushed the weijiii/allow-disable-iceberg-new-table-location-empty-check branch from 0b4889d to 17983ff Compare April 24, 2024 00:47
@cla-bot cla-bot bot added the cla-signed label Apr 24, 2024
@weijiii weijiii force-pushed the weijiii/allow-disable-iceberg-new-table-location-empty-check branch from 17983ff to 410054e Compare April 24, 2024 02:02
@weijiii weijiii force-pushed the weijiii/allow-disable-iceberg-new-table-location-empty-check branch from 410054e to 4ba254e Compare April 24, 2024 16:46
@weijiii weijiii marked this pull request as ready for review April 24, 2024 19:49
@weijiii weijiii requested a review from ebyhr April 24, 2024 20:34
@weijiii weijiii closed this Apr 26, 2024
@weijiii weijiii reopened this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

None yet

1 participant