Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify register_table requirement #21874

Merged
merged 1 commit into from
May 29, 2024
Merged

Clarify register_table requirement #21874

merged 1 commit into from
May 29, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented May 8, 2024

Description

  • Add info that it has to be enabled in the catalog
  • Delta Lake and Iceberg connectors

This seems to have caught numerous users off guard. Maybe we should change the default to true in the longer run .. but at least this doc is required. Also I am only assuming that this also applies to unregister .. maybe @findinpath and @ebyhr can confirm?

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label May 8, 2024
@github-actions github-actions bot added the docs label May 8, 2024
@mosabua mosabua requested a review from jhlodin May 8, 2024 18:20
@mosabua
Copy link
Member Author

mosabua commented May 8, 2024

Also fyi @kpayne

Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nits for the commas (you only put a comma before a conjunction if what follows the conjunction is an independent clause), but LGTM

docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Show resolved Hide resolved
@mosabua mosabua force-pushed the reg branch 3 times, most recently from 265d873 to 17efd7e Compare May 9, 2024 00:13
Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo

docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented May 29, 2024

Good now @ebyhr ?

docs/src/main/sphinx/connector/delta-lake.md Outdated Show resolved Hide resolved
- Add info that it has to be enabled in the catalog
- Delta Lake and Iceberg connectors
@mosabua mosabua merged commit e44ab7f into trinodb:master May 29, 2024
4 of 8 checks passed
@mosabua mosabua deleted the reg branch May 29, 2024 22:49
@github-actions github-actions bot added this to the 449 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants