Add concurrent writes reconciliation for OPTIMIZE in Delta Lake #22443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
force-pushed
the
findinpath/delta-lake-optimize-reconciliation
branch
2 times, most recently
from
c3fe9e8
to
9264397
Compare
findinpath
force-pushed
the
findinpath/delta-lake-optimize-reconciliation
branch
from
9264397
to
f4be087
Compare
Allow committing OPTIMIZE operations in a concurrent context by placing these operations right after any other previously concurrently completed write operations.
findinpath
force-pushed
the
findinpath/delta-lake-optimize-reconciliation
branch
from
f4be087
to
e695b50
Compare
pajaks
reviewed
Jun 24, 2024
Comment on lines
+2538
to
+2542
| // Note: during writes we want to preserve original case of partition columns | ||
| List<String> partitionColumns = getPartitionColumns( | ||
| optimizeHandle.getMetadataEntry().getOriginalPartitionColumns(), | ||
| optimizeHandle.getTableColumns(), | ||
| getColumnMappingMode(optimizeHandle.getMetadataEntry(), optimizeHandle.getProtocolEntry())); |
There was a problem hiding this comment.
Can we put it inside commitOptimizeOperation function?
| .build()) | ||
| .forEach(MoreFutures::getDone); | ||
|
|
||
| assertThat(query("SELECT * FROM " + tableName)).matches("VALUES (1, 10), (2, 10), (11, 20), (12, 20), (21, 30), (22, 30)"); |
There was a problem hiding this comment.
Shouldn't we check file count to verify that OPTIMIZE actually happen?
| ExecutorService executor = newFixedThreadPool(threads); | ||
| String tableName = "test_concurrent_optimize_and_inserts_table_" + randomNameSuffix(); | ||
|
|
||
| assertUpdate("CREATE TABLE " + tableName + " (a, part) WITH (partitioned_by = ARRAY['part']) AS VALUES (1, 10), (11, 20)", 2); |
There was a problem hiding this comment.
Can you add more files, so that OPTIMIZE can rewrite something?
| .build()) | ||
| .forEach(MoreFutures::getDone); | ||
|
|
||
| assertThat(query("SELECT * FROM " + tableName)).matches("VALUES (1, 10), (8, 10), (11, 20), (21, 30)"); |
There was a problem hiding this comment.
Can we check that OPTIMIZE actually changed something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow committing
OPTIMIZEoperations in a concurrent contextby placing these operations right after any other previously
concurrently completed write operations.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: