disable socket factory pre JDK8u242 #5915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. At this point, I think we should remove You can change the commit title to something like
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my presto version is 0.214 and my upgrade plan is in progress . At 0.214 , I hit the same issue: #1169 and it was fixed by this PR :#2633 . But this PR is ok for JDK11 or later, It will slow down of presto-cli and presto-jdbc in some JDK8 environment, for example JDK8u261.
The codes still need to be optimized. According to this link: https://www.eclipse.org/jetty/documentation/current/alpn-chapter.html , I think It shoud be like this :
return StandardSystemProperty.JAVA_VERSION.value().compareTo("1.8.0_242") > 0;so I commit this PR.I tested the code ,it works fine in JDK8u261.
I know the prestosql current version no longer supports jdk8, so I don't know wether this PR is necessary or not .
Please review , thx!