Simplify docker image configuration #6497
Conversation
findepi
force-pushed
the
findepi/simplify-docker-image-configuration-29b31e
branch
from
800cfc6
to
3b68aac
Compare
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| * Publish image as [`trinodb/trino`](https://hub.docker.com/r/trinodb/trino). | |||
| * Change base image to `azul/zulu-openjdk-centos`. | |||
| * Change configuration directories to `/usr/lib/trino/etc` and `/etc/trino`. | |||
| * Change configuration directory to `/etc/trino`. | |||
There was a problem hiding this comment.
Why are you changing release notes for past release?
There was a problem hiding this comment.
So that they do not misguide users. I am on the fence with this though, I can retract the change.
There was a problem hiding this comment.
I do not expect anyone will read the source code of release notes. But rather https://trino.io/docs/current/release/release-351.html
There was a problem hiding this comment.
Of course, the intention would be to republish the release notes (just the same way as we did in 5ae1a10), but again I can back it out if you want me to.
There was a problem hiding this comment.
Oh - I did not know we do that. Fine. Keep the change.
There was a problem hiding this comment.
We don't generally update the published documentation for a specific release, but release notes are part of the documentation, so any changes for a past release note would be present when the next release is published.
For this change, since we intend to break it in 352, I would want to republish the release notes immediately.
findepi
force-pushed
the
findepi/simplify-docker-image-configuration-29b31e
branch
from
3b68aac
to
593644f
Compare
|
@losipiuk PTAL |
| @@ -19,7 +19,8 @@ WORK_DIR="$(mktemp -d)" | |||
| curl -o ${WORK_DIR}/trino-server-${TRINO_VERSION}.tar.gz ${SERVER_LOCATION} | |||
| tar -C ${WORK_DIR} -xzf ${WORK_DIR}/trino-server-${TRINO_VERSION}.tar.gz | |||
| rm ${WORK_DIR}/trino-server-${TRINO_VERSION}.tar.gz | |||
| cp -R bin default ${WORK_DIR}/trino-server-${TRINO_VERSION} | |||
| cp -R bin ${WORK_DIR}/trino-server-${TRINO_VERSION} | |||
| cp -R default -t ${WORK_DIR} | |||
There was a problem hiding this comment.
Previously the default was applied dynamically in startup script
trino/core/docker/bin/run-trino
Line 9 in 297ba4d
now it's statically applied just by the fact it's in the expected place in the image.
There was a problem hiding this comment.
Oh yeah. I see where it is referenced now.
As we are breaking things anyway, this is a good occasion to clean things up and keep only one dir as supported.
findepi
force-pushed
the
findepi/simplify-docker-image-configuration-29b31e
branch
from
593644f
to
8a82b88
Compare
|
squashed |
After the change in Trino file structures (trinodb#6497), this document was not updated. You can see that this document page is the same in both current and old versions: https://trino.io/docs/current/connector/mysql.html https://prestodb.io/docs/current/connector/mysql.html Because the similarities in the old and new file structures, this document became confusing. Before the catalogs were in `/usr/lib/trino/etc`. Now they are in `/etc/trino/`. This nuance resulted in missing catalogs in the new version. See also: https://trinodb.slack.com/archives/CGB0QHWSW/p1652278657730469
As we are breaking things anyway, this is a good occasion to clean
things up and keep only one dir as supported.