Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 352 release notes #6751

Merged
merged 1 commit into from Feb 10, 2021
Merged

Add 352 release notes #6751

merged 1 commit into from Feb 10, 2021

Conversation

martint
Copy link
Member

@martint martint commented Jan 28, 2021

Closes #6502

@cla-bot cla-bot bot added the cla-signed label Jan 28, 2021
@martint martint added this to the 352 milestone Jan 28, 2021
@martint martint requested review from a team and mosabua January 28, 2021 17:58
* Support user impersonation when using password-based authentication. This is configured
using `sessionUser` connection URL parameter. Previously user impersonation was possible
only with other authentication mechanisms. ({issue}`6549`)
* Add OAuth2 authentication support.({issue}`6576`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should have some docs to link to .. but I am not aware of any as of yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is coming after the release @sopel39 so I am fine with closing this comment


## MySQL Connector

* Improve performance for certain complex queries involving aggregation and predicates (e.g. `HAVING` clause)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove "certain"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same applies to a bunch of other entries below .. I know we want to be kind of vague since it does not work for all queries .. but its still kind of weird to say "certain queries". Either remove or replace with "some queries"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove "certain"

it is intentionally vague, as we're not improving all the queries.
By dropping "vague" we would advertise more than we actually deliver

Comment on lines 16 to 20
* Fix query failure when using element of `array(timestamp(p))` in a complex expression
for `p` greater than 6. ({issue}`6350`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this applies to timestamp with time zone (p>3) and time with time zone (p>9) types too

8228acb / #6467

docs/src/main/sphinx/functions/window.rst Outdated Show resolved Hide resolved
`US/Pacific-New` zone, as it has been removed. ({issue}`6660`)
* Improve performance of queries using {func}`rank()` window function. ({issue}`6333`)
* Improve performance of {func}`sum` and {func}`avg` for `decimal` types. ({issue}`6951`)
* Improve join performance. ({issue}`5981`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every join, or some particular shapes of it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sopel39 sopel39 Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve performance of joins where duplicated join output rows can be skipped. I'm not sure if it's not too detailed though.

Comment on lines 14 to 15
* Fix window and streaming aggregation semantics regarding peer rows. Now peer rows are
not distinct from each other, while previously they had to been equal. ({issue}`6472`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should this be "Fix incorrect query results when .." form?
  • Also, how a user is gonna know what a streaming aggregation is, or whether they should care?
  • As we're talking about "peer rows", this seems applicable to window. Let's split this bullet into two separate things -- window case, talking about peer rows, and [streaming] aggregation case (not talking about peer rows).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or @erichwang ?

docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
Comment on lines +49 to +63
* Support reading timestamp with microsecond or nanosecond precision (as configured with
`hive.timestamp-precision` property) nested within `array`, `map` or `struct` data types. ({issue}`5195`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally support writes too, except for some bugs in Parquet.
Am i correct @jirassimok ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support writes for ORC, RC binary, and RC text (i.e. the formats that have their own writers).

After #6622, we can write in everything except Parquet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support writes for ORC, RC binary, and RC text (i.e. the formats that have their own writers).

@jirassimok but the "hive native" writers work too, right? so we can write to eg a TEXTFILE as well?

After #6622, we can write in everything except Parquet.

That PR is tests-only. So after #6622 we know we can write to anything (except Parquet),
but from user perspective (and so from RNs perspective), we can write even today.
Since that PR is green (or was green earlier), we can declare read/write support already (except Parquet).

Copy link
Member

@jirassimok jirassimok Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hive native" writers work too, right?

No, because there are two explicit checks for TIMESTAMP_MILLIS in HiveWriteUtils.

docs/src/main/sphinx/release/release-352.md Show resolved Hide resolved

## MySQL Connector

* Improve performance for certain complex queries involving aggregation and predicates (e.g. `HAVING` clause)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove "certain"

it is intentionally vague, as we're not improving all the queries.
By dropping "vague" we would advertise more than we actually deliver

docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved

## MySQL connector

* Improve performance for certain complex queries involving aggregation and predicates (e.g. `HAVING` clause)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and 'accidentally' this also adds aggregation pushdown for distinct aggregations, when there is only one aggregation function. So eg count(DISTINCT x) is now pushed down (without or with group by).

## Web UI

* Support JWK with certificate chain for OAuth2 authorization. ({issue}`6428`)
* Optionally verify JWT audience (`aud`) field for OAuth2 Web UI authentication. ({issue}`6501`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is optionality driven by? Should we reference config property here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config property is here: http-server.authentication.oauth2.audience, if specified then we require token to have this audience set.

Currently, we are still missing docs for entire feature. We are going to add it soon.

FYI @s2lomon @lukasz-walkiewicz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, this doesn't seem specific to web UI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll move it to a Security section

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments were addressed or are in discussion with others, so from my perspective this can go out.

docs/src/main/sphinx/release/release-352.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-352.md Outdated Show resolved Hide resolved

* Add OAuth2 authentication. ({issue}`6576`)
* Support user impersonation when using password-based authentication
using the new `sessionUser` parameter. ({issue}`6549`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extrra space here

* Optimize cardinality-insensitive aggregations ({func}`max`, {func}`min`, {func}`distinct`, {func}`approx_distinct`)
over identity partition columns with `optimizer.optimize-metadata-queries` config property
or `optimize_metadata_queries` session property. ({issue}`5199`)
* Provide `use_file_size_from_metadata` catalog session property and `iceberg.use-file-size-from-metadata`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space here

@martint martint merged commit e562570 into trinodb:master Feb 10, 2021
@martint martint deleted the relnotes branch February 10, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Release notes for 352