Support LATERAL VIEW json_tuple AS ... in Hive VIEW #7420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Mar 25, 2021
Merged
findepi
force-pushed
the
json_tuple
branch
2 times, most recently
from
98a5b23
to
85445a4
Compare
losipiuk
approved these changes
Mar 29, 2021
| onTrino().executeQuery("DROP TABLE IF EXISTS test_json_tuple_table"); | ||
| onTrino().executeQuery("" + | ||
| "CREATE TABLE test_json_tuple_table AS " + | ||
| "SELECT 3 id, CAST('{\"user_id\": 1000, \"first.name\": \"Mateusz\", \"Last Name\": \"Gajewski\", \".NET\": true}' AS varchar) jsonstr"); |
There was a problem hiding this comment.
@wendigo please review this query ;)
There was a problem hiding this comment.
it's ok but can we @findepi add an non-existent field as well (which should yield NULL)
There was a problem hiding this comment.
Adding. And adding a field with json null value as well.
| "SELECT 3 id, CAST('{\"user_id\": 1000, \"first.name\": \"Mateusz\", \"Last Name\": \"Gajewski\", \".NET\": true}' AS varchar) jsonstr"); | ||
|
|
||
| onHive().executeQuery("DROP VIEW IF EXISTS test_json_tuple_view"); | ||
| onHive().executeQuery("CREATE VIEW test_json_tuple_view AS " + |
There was a problem hiding this comment.
looks good. Do you support the cN syntax alrady (without explicit column names)?
There was a problem hiding this comment.
Wording copied from session property.
findepi
changed the title
|
AC; updated to a release of Coral and fixed title, commit message to indicate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7242