Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 355 release notes #7501

Merged
merged 1 commit into from Apr 8, 2021
Merged

Add 355 release notes #7501

merged 1 commit into from Apr 8, 2021

Conversation

martint
Copy link
Member

@martint martint commented Apr 5, 2021

Closes #7366

docs/src/main/sphinx/release/release-355.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-355.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-355.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-355.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-355.md Outdated Show resolved Hide resolved
* Fix inconsistent behavior for {func}`to_unixtime` with values of type `timestamp(p)`. ({issue}`7450`)
* Change return type of {func}`from_unixtime` and {func}`from_unixtime_nanos` to `timestamp(p) with time zone`. ({issue}`7460`)
* Report tables referenced in materialized views to even listener. ({issue}`7483`)
* Report columns which are created/inserted/updated to event listener. ({issue}`7425`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"created, inserted or updated"

also, would be good to mention where this information can be seen (QueryCompletedEvent > ioMetadata > output > columns)

docs/src/main/sphinx/release/release-355.md Outdated Show resolved Hide resolved
Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes added so far look good to me.

docs/src/main/sphinx/release/release-355.md Outdated Show resolved Hide resolved
@@ -0,0 +1,52 @@
# Release 355 (XX Apr 2021)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update before merging


## SPI

* Engine now uses `ConnectorMaterializedViewDefinition#storageTable`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bug fix

* Use `ConnectorMaterializedViewDefinition.getStorageTable()`
  to determine the storage table for materialized views.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's a bugfix

docs/src/main/sphinx/release/release-355.md Outdated Show resolved Hide resolved
This optimization is now triggered automatically when the ratio between table buckets and
possible table scan tasks exceeds or is equal to `optimizer.table-scan-node-partitioning-min-bucket-to-task-ratio`. ({issue}`7257`)
* Include information about {doc}`/admin/spill` in {doc}`/sql/explain-analyze`. ({issue}`7427`)
* Disallow inserting data into tables that have row filters. ({issue}`7346`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Disallow inserting data into tables that have row filters. ({issue}`7346`)
* Disallow inserting data into a table that has a row filter. ({issue}`7346`)

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plural form is fine. It's a reference to tables and row filters in the general sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this reads OK. It would be great to have a guideline whether we prefer plural (general sense) or singular forms.

## Hive connector

* Support Hive views containing `LATERAL VIEW json_tuple(...) AS ...` syntax. ({issue}`7242`)
* Fix incorrect results when reading from a Hive view that uses array subscript operators. ({issue}`7271`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operators -> operator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "operators" is fine -- it's a reference to array subscript operators in the general sense, not refering to multiple operators. Otherwise, it would need to read "a Hive view that uses an array subscript operator".

@martint martint merged commit 9aad232 into trinodb:master Apr 8, 2021
@martint martint deleted the relnotes branch April 8, 2021 22:38
@martint martint added this to the 355 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Release notes for 355
7 participants