Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compiler warning for reserved identifier in future JDKs #9536

Merged
merged 1 commit into from Oct 7, 2021
Merged

Remove compiler warning for reserved identifier in future JDKs #9536

merged 1 commit into from Oct 7, 2021

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 6, 2021

yield will be a reserved identifier in future JDK versions. On JDK 17 compiler generates warning for that name.

@cla-bot cla-bot bot added the cla-signed label Oct 6, 2021
@wendigo wendigo requested a review from findepi October 6, 2021 19:18
@wendigo
Copy link
Contributor Author

wendigo commented Oct 6, 2021

I couldn't came up with a better replacement for that name. Ideas? @losipiuk @findepi @ebyhr

@ebyhr ebyhr merged commit 81e90ce into trinodb:master Oct 7, 2021
@ebyhr
Copy link
Member

ebyhr commented Oct 7, 2021

Merged, thanks!

@wendigo wendigo deleted the serafin/replace-yield branch October 7, 2021 08:35
@github-actions github-actions bot added this to the 364 milestone Oct 7, 2021
@findepi
Copy link
Member

findepi commented Oct 8, 2021

@sopel39 PTAL, cc @raunaqmorarka

@martint martint mentioned this pull request Nov 4, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

@ebyhr ebyhr ebyhr approved these changes

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed
Milestone
364
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wendigo @ebyhr @findepi @electrum