-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support user defined type in Cassandra #9685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Oct 19, 2021
plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 19, 2021
plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraType.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 19, 2021
plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 19, 2021
plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 19, 2021
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraTestingUtils.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 19, 2021
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraConnector.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some editorials
ebyhr
force-pushed
the
ebi/cassandra-udt
branch
from
October 19, 2021 12:11
4a9b3a6
to
e7f797f
Compare
@losipiuk Thanks for your quick review. Updated > force-pushed diff |
ebyhr
force-pushed
the
ebi/cassandra-udt
branch
from
November 2, 2021 00:41
e7f797f
to
835bf2a
Compare
|
losipiuk
approved these changes
Nov 2, 2021
ebyhr
force-pushed
the
ebi/cassandra-udt
branch
from
November 4, 2021 14:04
835bf2a
to
8941691
Compare
ebyhr
force-pushed
the
ebi/cassandra-udt
branch
from
November 5, 2021 03:19
b0f63da
to
c91aace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147