[github actions] address test flakiness #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allibell
commented
Feb 14, 2022
allibell
changed the title
allibell
commented
Feb 14, 2022
allibell
commented
Feb 14, 2022
allibell
commented
Feb 14, 2022
allibell
requested review from
fundthmcalculus and
tmarkovski
as code owners
allibell
commented
Feb 14, 2022
allibell
commented
Feb 14, 2022
fundthmcalculus
approved these changes
Feb 14, 2022
allibell
commented
Feb 14, 2022
tmarkovski
approved these changes
Feb 14, 2022
Comment on lines
228
to
229
| if build_all or 'docs' in langs_to_build: | ||
| build_java_docs(args) | ||
| build_dotnet_docs(args) |
There was a problem hiding this comment.
we should switch this to dotnet then.
Comment on lines
+37
to
+50
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: '14' | ||
| - name: Set up Node (docs) | ||
| run: | | ||
| npm install groovydoc-to-markdown | ||
| shell: pwsh | ||
| - uses: actions/setup-dotnet@v1 | ||
| with: | ||
| dotnet-version: '6.0.x' | ||
| - name: Set up Dotnet (docs) | ||
| run: | | ||
| dotnet tool install DefaultDocumentation.Console -g | ||
| shell: pwsh |
There was a problem hiding this comment.
dotnet isn't necessary for java.
There was a problem hiding this comment.
ah, I thought we might need to build dotnet docs with all of them since build-dotnet workflow doesn't call this build_sdks script. but that's probably the real problem, we should make it call the script and allow for a real "build all" option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want green checkmarks! :) We should be able to trust these or else real failures will be ignored.
don't build docs by defaultbuilt only the needed docs, set up doc dependencies in the Action workflowa. actually download
C_headerartifact (okapi.h)b. fix LD linking for Windows/MacOS
d. get lib artifacts for windows-gnu
e. nit (but need to appease
go test): add comments to exported interfacesTests
commit triggers: I tested this on the test-github-stuff branch - finally the checkmarks are consistently green and the published XML test reports are all successes! (if you look back through past commits, the XML test reports had usually been failures, especially golang MacOS/Windows)
PR triggers (this PR): we have but one failure left, MacOS codesigning. >:( might we need to update these secrets?