Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various dart fixes #430

Merged
merged 4 commits into from
May 24, 2022
Merged

Various dart fixes #430

merged 4 commits into from
May 24, 2022

Conversation

fundthmcalculus
Copy link
Contributor

This is bunch of minor things I've found as part of building the Dart services SDK.

@fundthmcalculus fundthmcalculus marked this pull request as ready for review May 24, 2022 19:11
@fundthmcalculus fundthmcalculus enabled auto-merge (squash) May 24, 2022 19:12
Copy link
Member

@geel9 geel9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and a few other recent PRs across the org have been very difficult to review due to a huge amount of files changed solely for style / formatting reasons.

We should have a conversation to figure out a way to keep PRs sane when large formatting changes are at play.

@fundthmcalculus fundthmcalculus merged commit 17dc90a into main May 24, 2022
@fundthmcalculus fundthmcalculus deleted the various-dart-fixes branch May 24, 2022 21:00
@fundthmcalculus
Copy link
Contributor Author

This and a few other recent PRs across the org have been very difficult to review due to a huge amount of files changed solely for style / formatting reasons.

We should have a conversation to figure out a way to keep PRs sane when large formatting changes are at play.

Yup, in the future, this won't be such an issue. I've been working (very casually in okapi repo) to add coding style checkers. Since Dart isn't officially supported, I wasn't worried about style PRs yet. Also, this PR moves to using dart format.

opens can of worms about style guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants