Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Android/iOS/Cordova Code Base #28

Open
tripflex opened this issue Apr 12, 2018 · 5 comments
Open

Refactor Android/iOS/Cordova Code Base #28

tripflex opened this issue Apr 12, 2018 · 5 comments
Labels
Android Dev's Needed Looking for help from any available Android Devs archive low priority archived issues or items Cordova Dev's Needed Looking for help from any devs with Cordova experience enhancement New feature or request help wanted Extra attention is needed

Comments

@tripflex
Copy link
Owner

tripflex commented Apr 12, 2018

After my initial fork of this plugin, things have been constantly growing and being added, resulting in a large single file with ~2k lines of code. Need to clean up code base, and move methods/functions/classes to separate files to keep clean codebase ... looking for any Android and Cordova developers out there who would be willing to help with this.

Let's get this thing cleaned up and organized! Unfortunately my time is limited as I do not have any projects using Cordova that bring in any kind of income, this was specifically for personal and other open source projects, so looking for others who may be willing to help!

@tripflex tripflex added enhancement New feature or request Android Dev's Needed Looking for help from any available Android Devs Cordova Dev's Needed Looking for help from any devs with Cordova experience help wanted Extra attention is needed labels Apr 12, 2018
@tripflex tripflex added the archive low priority archived issues or items label Feb 7, 2019
@tripflex
Copy link
Owner Author

tripflex commented Apr 4, 2019

https://github.com/dpa99c/cordova-diagnostic-plugin/

This plugin is a perfect example of a well organized and clean code base for Cordova project

@tripflex tripflex changed the title [3.0.0] - Refactor Android Code Base Refactor Android/iOS/Cordova Code Base Apr 4, 2019
@kalicki
Copy link

kalicki commented Apr 5, 2019

ios: idea.. refactor to swift (4/5)

@CurtisMorice
Copy link

I am working with this in my app everyday and would like to help if I can. I am pretty junior and have only been coding about a year now. How can I help?

@arsenal942
Copy link
Collaborator

I am working with this in my app everyday and would like to help if I can. I am pretty junior and have only been coding about a year now. How can I help?

@CurtisMorice Just like any other open-source project, if you see room for improvement, submit a pull request so it can be reviewed. :)

@AbdulRahman577
Copy link

May I get the example for migrating this to implement in the capacitor app?
What I have done is, just copy the java file into the Android app main directory as the subpackage and then add this wifiwizard.java file as a custom plugin in the capacitor.config.json. And some thing modified inside the wifiwizard2.java as for the capacitor framework,
which is,
import com. getcapacitor.CapacitorPlugin;

public class WifiWizard2 extends CapacitorPlugin {....

Like above,

is my implementation is correct for capacitor environment?

And how to remove the cordova interface in the wifiwizard2.java file, Or is it okay to be there for building?
Please suggest way to understand this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Dev's Needed Looking for help from any available Android Devs archive low priority archived issues or items Cordova Dev's Needed Looking for help from any devs with Cordova experience enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants