Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration Process #3

Closed
DanVanAtta opened this issue Jul 28, 2015 · 4 comments
Closed

Continuous Integration Process #3

DanVanAtta opened this issue Jul 28, 2015 · 4 comments

Comments

@DanVanAtta
Copy link
Member

I'd like us to agree on a continuous integration process and to document it on the github wiki.

Definition: continuous integration means the work of multiple developers is integrated together on a short iteration cycle. Meaning, merge conflicts that come up are small and not so frequent.

Proposal: simply use master branch for integration. Pull requests will add new code, "git pull --rebase" to pull down remote code and integrate it locally.

@ron-murhammer
Copy link
Member

Yep. Everyone should fork the repo and submit pull requests for Veqyrn and I to review for now.

@ron-murhammer
Copy link
Member

I'll add one more important point which is please make small commits that are properly commented. Its much easier to review small commits that make it obvious what they are doing rather than huge commits that make lots of changes. It also allows us to accept changes at a finer grain rather than having to reject a large commit because of an issue with a small part of it.

This is especially important since there are only 2 of us reviewing pull requests right now and Veqryn has been pretty busy recently.

@DanVanAtta
Copy link
Member Author

@ron-murhammer I want to avoid confusion and be clear on what this process would look like (I think there is some confusion since forks are not so pertinent):

  • all the time there are pull requests going into triplea/master, and developers pull from it in order to integrate. Periodically a release branch is cut, tested in more detail, bug fixes are applied to it + master, and a release happens. That branch is "thrown away" and the process repeats.

Continuous integration means integrating often, my intent here is to designate master/triplea as the integration branch. This means dev's push there often and pull from there so that they integrate often.

@DanVanAtta
Copy link
Member Author

Closing, at some point maybe later today I'll try to document this on the wiki. The integration+release process I think should be documented somewhere, probably there.

DanVanAtta pushed a commit that referenced this issue Apr 11, 2016
DanVanAtta pushed a commit that referenced this issue Aug 18, 2016
simon33-2 pushed a commit to simon33-2/triplea that referenced this issue Sep 15, 2016
@americanknight americanknight mentioned this issue Dec 22, 2016
11 tasks
simon33-2 pushed a commit to simon33-2/triplea that referenced this issue Dec 7, 2018
ron-murhammer pushed a commit that referenced this issue Dec 17, 2018
* Rocket fixes

* Update serialization

* Review feedback plus fix bug with second rocket

* Review feedback

* Ron's review feedback

* Ron's review feedback #2

* Review feedback #3

* Review feedback #4

* Fix rebasing errors

* Fix 2 bugs - Infinite not working properly & multiple tech ownership causing accumulation bugs

* Update test for new parameter

* Fix for retentive grammar rule
beelee1 added a commit to beelee1/triplea that referenced this issue Jan 20, 2021
Fixes damaged Factories not repairing. There is a PR in the camp_david repo that fixes it. Should be merged after the camp_david PR triplea-game#3
DanVanAtta pushed a commit that referenced this issue Jan 20, 2021
Fixes damaged Factories not repairing. There is a PR in the camp_david repo that fixes it. Should be merged after the camp_david PR #3
frigoref referenced this issue in frigoref/triplea Mar 26, 2022
contribute.md
- icons try2
asvitkine pushed a commit that referenced this issue May 30, 2022
* docuStartContribute #1

contribute.md
- Initial page "Contribute to TripleA"

README.md
- Link to new page "Contribute to TripleA"

* docuStartContribute #1

contribute.md
- Initial page "Contribute to TripleA"

README.md
- Link to new page "Contribute to TripleA"

* docuStartContribute #2

contribute.md
- icons try 1

* docuStartContribute #3

contribute.md
- icons try2

* docuStartContribute #4

contribute.md
- cleanup

* docuStartContribute #5

contribute.md
- New role: Donor
. Map Maker: Skillset

* Update contribute.md

The Rules Guru profile. I changed "Guru" to "Expert" however 😃 .

* Rule Expert link + Capitalization of Roles

* Update Forum Moderator

See if i did this correctly lol

* Update contribute.md

Added to Map Maker Skillset

* docuStartContribute #6

contribute.md
- New roles: Map Admin, Release Tester

* Contribute page: TBD for Release Tester + Developer with Merge Rights

🔍 Release Tester - How to become one
🔨 Developer with Merge Rights - How to become one

* Update contribute.md

See the differences.

* Forum Moderator -> Lobby Moderator #2

renaming/linking

* ContributePage: Remove *Work in Progress*

Co-authored-by: Panther P2 <panther2@users.noreply.github.com>
Co-authored-by: beelee1 <timbucktoomany@gmail.com>
Co-authored-by: TheDog-GH <71022517+TheDog-GH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants