New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map key listeners are not consistently active #305

Closed
DanVanAtta opened this Issue Dec 29, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@DanVanAtta
Member

DanVanAtta commented Dec 29, 2015

It appears in multiplayer games the key listener for the 'n' key (select next unit) is not kept around properly. In single player games I have not seen this problem. In multiplayer sometimes you have to click the map or interact with it for the key listener to be "recreated". At that point the "n" key is then active.

Debugging the code, when this problem occurs the event handler code for the "n" key press event is not executed at all (hence the hypothesis that the key listener is being destroyed and recreated)

@DanVanAtta

This comment has been minimized.

Show comment
Hide comment
@DanVanAtta

DanVanAtta Jan 11, 2016

Member

I'd like to state explicitly,the impact of this bug: this is why most lobby players still believe that the 'n' and 'f' keys do not work. Initial launch of those features never worked very well, and now after being 'fixed', still does not work consistently. I personally gave up on using those two feature keys, and I'm quite sure many others have as well.

Member

DanVanAtta commented Jan 11, 2016

I'd like to state explicitly,the impact of this bug: this is why most lobby players still believe that the 'n' and 'f' keys do not work. Initial launch of those features never worked very well, and now after being 'fixed', still does not work consistently. I personally gave up on using those two feature keys, and I'm quite sure many others have as well.

@DanVanAtta

This comment has been minimized.

Show comment
Hide comment
@DanVanAtta

DanVanAtta May 17, 2016

Member

Bumping this up since I run into this all the time. "F" is now very useful now that the highlight is strong. I keep clicking the map as a work-around to allow the "F" to key to then work. Same thing for undoing with "u" key.
@RoiEXLab , @frigoref , this is an excellent one to pick up if you have the capacity.

Member

DanVanAtta commented May 17, 2016

Bumping this up since I run into this all the time. "F" is now very useful now that the highlight is strong. I keep clicking the map as a work-around to allow the "F" to key to then work. Same thing for undoing with "u" key.
@RoiEXLab , @frigoref , this is an excellent one to pick up if you have the capacity.

@DanVanAtta

This comment has been minimized.

Show comment
Hide comment
@DanVanAtta

DanVanAtta Jun 7, 2016

Member

This is an important fix, the "f" and "n" key seem broken unless a person knows to click on the map first, which is very non-intuitive.

Member

DanVanAtta commented Jun 7, 2016

This is an important fix, the "f" and "n" key seem broken unless a person knows to click on the map first, which is very non-intuitive.

@RoiEXLab

This comment has been minimized.

Show comment
Hide comment
@RoiEXLab

RoiEXLab Jun 7, 2016

Member

I think I can pick up this one...

Member

RoiEXLab commented Jun 7, 2016

I think I can pick up this one...

@RoiEXLab RoiEXLab referenced this issue Jun 20, 2016

Merged

Small cleanup #866

@RoiEXLab

This comment has been minimized.

Show comment
Hide comment
@RoiEXLab

RoiEXLab Jul 16, 2016

Member

@DanVanAtta I might have an Idea what could be causing this...
I found this Question on Stackoverflow, leading to the possibility that this issue is due to the delay of multiplayer games...
Any ideas where this could be happening?

Member

RoiEXLab commented Jul 16, 2016

@DanVanAtta I might have an Idea what could be causing this...
I found this Question on Stackoverflow, leading to the possibility that this issue is due to the delay of multiplayer games...
Any ideas where this could be happening?

@DanVanAtta

This comment has been minimized.

Show comment
Hide comment
@DanVanAtta

DanVanAtta Jul 16, 2016

Member

I've seen in some places we "clean up" listeners. I've suspected this is due to us removing the listener in multiplayer games, and then not adding it back until a click event has happened on the map.

Member

DanVanAtta commented Jul 16, 2016

I've seen in some places we "clean up" listeners. I've suspected this is due to us removing the listener in multiplayer games, and then not adding it back until a click event has happened on the map.

@RoiEXLab

This comment has been minimized.

Show comment
Hide comment
@RoiEXLab

RoiEXLab Jul 17, 2016

Member

@DanVanAtta

I've seen in some places we "clean up" listeners.

That's what I couldn't find... but maybe I searched for the wrong thing... If you can still find a place, please tell me...

Member

RoiEXLab commented Jul 17, 2016

@DanVanAtta

I've seen in some places we "clean up" listeners.

That's what I couldn't find... but maybe I searched for the wrong thing... If you can still find a place, please tell me...

@DanVanAtta DanVanAtta changed the title from key listener for 'n' key is not consistently active in multiplayer games to map key listeners are not consistently active Oct 14, 2017

@DanVanAtta

This comment has been minimized.

Show comment
Hide comment
@DanVanAtta

DanVanAtta Oct 14, 2017

Member

New simpler repro:

  • move a unit
  • hover over unit and press 'u'

Expect:

  • move to be undone

Actual:

  • nothing happens

Note, if you click the map anywhere, then repeat the hover and 'u' action, then the mvoe will be undone as expected.

Member

DanVanAtta commented Oct 14, 2017

New simpler repro:

  • move a unit
  • hover over unit and press 'u'

Expect:

  • move to be undone

Actual:

  • nothing happens

Note, if you click the map anywhere, then repeat the hover and 'u' action, then the mvoe will be undone as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment