Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo README Review #3289

Closed
7 tasks
DanVanAtta opened this issue Mar 17, 2018 · 11 comments
Closed
7 tasks

Repo README Review #3289

DanVanAtta opened this issue Mar 17, 2018 · 11 comments
Labels
Discussion team communication thread, meant for coordination and decision making

Comments

@DanVanAtta
Copy link
Member

DanVanAtta commented Mar 17, 2018

Does each repo contain a top level README.md with:

  1. overview of the repo contents and how it fits in with the rest of the system
  2. compile and build
  3. test locally
  4. deploy
  5. restart
  6. check status (is it alive?)
  7. check logs

https://github.com/triplea-game

@DanVanAtta
Copy link
Member Author

@RoiEXLab @ssoloff can either of you volunteer to consolidate any existing dice server documentation to the corresponding repo?

@ssoloff
Copy link
Member

ssoloff commented Mar 17, 2018

Sorry, don't have bandwidth at the moment for additional tasks. If you have specific questions, please list them, and I'll try to answer them when I get a chance.

@DanVanAtta
Copy link
Member Author

DanVanAtta commented Mar 18, 2018

A few questions that would really help @ssoloff / @RoiEXLab :

  • Are both dice servers deployed?
  • Which one is legacy?
  • Is there any documentation on deployment/installation beyond the section in docs/admin?

@RoiEXLab
Copy link
Member

@DanVanAtta

Are both dice servers deployed?

Well we currently have a staging an a production version of MARTI. Nothing else.

Which one is legacy?

While I started a rewrite from scratch project that can be found in the dice-server-js repository it doesn't work yet.
But the long term goal is to replace MARTI with a REST API.

Is there any documentation on deployment/installation beyond the section in docs/admin?

There's just MARTI. @ssoloff Created a docker image that could be used for production (well documented in the MARTI repository), but other than that I don't think there's a documentation on how to set everything up without docker

@DanVanAtta
Copy link
Member Author

Sorry< i was not clear enough with first question. Out of these two repositories, which ones are deployed?

From your answer @RoiEXLab , it sounds like the 2nd one dice-server is currently deployed and the *js is work in progress.

@DanVanAtta
Copy link
Member Author

Is there any documentation on deployment/installation beyond the section in docs/admin?

There's just MARTI. @ssoloff Created a docker image that could be used for production (well documented in the MARTI repository), but other than that I don't think there's a documentation on how to set everything up without docker

Where is the MARTI repository? 🤔 I don't see it under: https://github.com/triplea-game/

@DanVanAtta
Copy link
Member Author

@RoiEXLab @ssoloff please update the dice-server repo's when you get the chance.

I'll take care of the other ones, I created most of them.

@DanVanAtta
Copy link
Member Author

Marking warclub:

If it turns out we still use this repo then we'll need to revisit this documentation, I suspect that is pretty likely given relatively recent commits.

@RoiEXLab
Copy link
Member

@DanVanAtta
The MARTI repository is just called 'dice-server'
To my knowledge the tripleawarclub.org repository just hosts some configuration files currently

@DanVanAtta
Copy link
Member Author

I updated the list of desired items for top level README's, added for example 'how to restart' . We are at six items now:

  1. overview of the repo contents and how it fits in with the rest of the system
  2. compile and build
  3. test locally
  4. deploy
  5. restart
  6. check status (is it alive?)
  7. check logs

Is that an agreeable list? Anything missing?

@ron-murhammer ron-murhammer added Discussion team communication thread, meant for coordination and decision making category: admin labels Apr 1, 2018
@DanVanAtta
Copy link
Member Author

Happily just one repo now is missing info and not otherwise marked as deprecated. I added a ticket to that repo, can resolve this ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion team communication thread, meant for coordination and decision making
Projects
None yet
Development

No branches or pull requests

4 participants