Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyBindings Fire When Chatting #5286

Closed
DanVanAtta opened this issue Sep 27, 2019 · 0 comments · Fixed by #5455
Closed

KeyBindings Fire When Chatting #5286

DanVanAtta opened this issue Sep 27, 2019 · 0 comments · Fixed by #5455
Assignees
@DanVanAtta
Labels
Problem A problem, bug, defect - something to fix

Comments

@DanVanAtta
Copy link
Member

DanVanAtta commented Sep 27, 2019 •
edited

Describe the bug
Keybindings are firing even when typing in chat

To Reproduce

  • Host a local network game
  • Type the word "fun", notice the 'f' and 'n' keystrokes activate key bindings

Expected behavior
Key bindings should not fire when typing in chat
@DanVanAtta DanVanAtta added Problem A problem, bug, defect - something to fix PR: Problem Fix labels Sep 27, 2019
@DanVanAtta DanVanAtta self-assigned this Nov 9, 2019
@DanVanAtta DanVanAtta mentioned this issue Nov 9, 2019
Merged
DanVanAtta added a commit that referenced this issue Nov 9, 2019
@DanVanAtta
Fix KeyBindings firing while chatting (#5455)
212574c 
While a user is typing in a text component, we do not want keybindings
to fire. For example, pressing space key skips current unit, typing
a few words would skip a few units.

To fix this we can set a keyboard focus listener to fire when keyboard
focus changes. We then check if focus is on a text component, if so
we disable key binding actions. When focus is off of the text component,
we re-enable the key binding actions.

Addresses: #5286
@RoiEXLab RoiEXLab mentioned this issue Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanVanAtta DanVanAtta

Labels
Problem A problem, bug, defect - something to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix KeyBindings firing while chatting
1 participant
@DanVanAtta