Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air Battle error popup (AI attacker) #9180

Open
butterw opened this issue Apr 30, 2021 · 2 comments
Open

Air Battle error popup (AI attacker) #9180

butterw opened this issue Apr 30, 2021 · 2 comments
Labels
Problem A problem, bug, defect - something to fix

Comments

@butterw
Copy link
Contributor

butterw commented Apr 30, 2021

Reproduction Steps

  1. Air Battle with attacker (Hard AI)
    Displays an error message box: must complete air_battle first.
    The error message box is not blocking and the result is correct.

Attach a Save Game

"World War II v5 1942 2nd" modified to add Air battle
WW2v5_1942aa_2nd.zip

ex: 1st turn RUS (Hard AI) attack GER (Hard AI or Human) in Ukraine, BRI Human player.

	<property name="Battles May Be Preceeded By Air Battles" value="true" editable="false">
		<boolean/>
	</property>
	<property name="Air Battle Rounds" value="1" editable="false">
		<number min="-1" max="100"/>
	</property>
etc.

Engine Version

Engine Version: v2.5 latest stable release (Win64)

@butterw butterw added the Problem A problem, bug, defect - something to fix label Apr 30, 2021
@butterw butterw changed the title AI vs AI Air Battle error popup Air Battle error popup (Hard AI attacker) May 2, 2021
@butterw butterw changed the title Air Battle error popup (Hard AI attacker) Air Battle error popup (AI attacker) May 21, 2021
@butterw
Copy link
Contributor Author

butterw commented May 21, 2021

The same error message occurs when a Human Player Attacker tries to do the land battle before the air battle in the same territory.

  • The preferred solution, would be to ensure the AI always performs the land battle before the air battle. Is this possible ?
  • Otherwise the fix could be to not display this error message if the attacker is AI.

@butterw
Copy link
Contributor Author

butterw commented May 21, 2021

Problem still occurs with latest pre-release:
20:22:05.862 [main] INFO o.t.game.client.HeadedGameRunner - Launching game, version: 2.6.184
20:22:58.425 [Thread-7] WARN g.s.triplea.ai.AbstractBuiltInAi - Must complete IBattle.BattleType.AIR_BATTLE(type=Air Battle) in Ukraine S.S.R. first
with Triplea Error popup: If this problem happens frequently and is something you cannot fix, please report it to TripleA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Problem A problem, bug, defect - something to fix
Projects
None yet
Development

No branches or pull requests

1 participant