Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors with map resources being not found in 2.6. #10504

Merged
merged 5 commits into from
May 25, 2022
Merged

Fix errors with map resources being not found in 2.6. #10504

merged 5 commits into from
May 25, 2022

Commits on May 25, 2022

  1. Fix errors with map resources being not found in 2.6. 

    This was caused by some maps having duplicate files (e.g. a polygon.txt file in baseTiles folder). Before this change, it's undefined which of these files will be found first and all other files will be expected to be alongside it.

With this change, the search returns files in a deterministic order, sorted by path length. So files closer to the root will be first in the list. This makes the behavior deterministic across platforms and the map to use the file closest to the map root.
    @asvitkine
    asvitkine committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f06cdda View commit details
    Browse the repository at this point in the history

  2. Fix comment.

    @asvitkine
    asvitkine committed May 25, 2022
    Configuration menu
    Copy the full SHA
    48bff99 View commit details
    Browse the repository at this point in the history

  3. Rename findAny() to findClosestToRoot() and improve javadoc comments.

    @asvitkine
    asvitkine committed May 25, 2022
    Configuration menu
    Copy the full SHA
    8519c08 View commit details
    Browse the repository at this point in the history

  4. Add test coverage and improve some comments.

    @asvitkine
    asvitkine committed May 25, 2022
    Configuration menu
    Copy the full SHA
    89b5558 View commit details
    Browse the repository at this point in the history

  5. Fix param.

    @asvitkine
    asvitkine committed May 25, 2022
    Configuration menu
    Copy the full SHA
    49fbc3a View commit details
    Browse the repository at this point in the history