Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include 1-player alliances in players and resource tabs. #10571

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

asvitkine
Copy link
Contributor

@asvitkine asvitkine commented Jun 3, 2022

Change Summary & Additional Notes

This fixes a 2.6 regression as previously this logic was in AbstractStatPanel.getAllianceMap().

Release Note

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #10571 (8df12a0) into master (27d0635) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #10571      +/-   ##
============================================
- Coverage     28.09%   28.08%   -0.02%     
+ Complexity     7985     7983       -2     
============================================
  Files          1197     1197              
  Lines         76945    76953       +8     
  Branches      10536    10538       +2     
============================================
- Hits          21617    21610       -7     
- Misses        53362    53377      +15     
  Partials       1966     1966              
Impacted Files Coverage Δ
...n/java/games/strategy/triplea/ui/EconomyPanel.java 0.00% <0.00%> (ø)
...main/java/games/strategy/triplea/ui/StatPanel.java 0.00% <0.00%> (ø)
...rc/main/java/games/strategy/net/nio/NioReader.java 82.50% <0.00%> (-3.75%) ⬇️
...rc/main/java/games/strategy/net/nio/NioWriter.java 79.16% <0.00%> (-2.09%) ⬇️
.../main/java/games/strategy/net/ClientMessenger.java 62.50% <0.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d0635...8df12a0. Read the comment docs.

@asvitkine asvitkine merged commit 08730c9 into triplea-game:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant