Configure nginx to send 2.5 clients to 2.6 lobby #11191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update would have NGINX (which is listening on 'prod.triplea-game.org') send 2.5 game clients to the 2.6 lobby (2.5 is the current 'main' release). The 2.6 lobby and 2.5 game clients are compatible with each other, so this is a safe configuration update to make. Though, 2.5 clients are currently configured to use a 'prod2' URL and they would see no difference. But, we can configure the 2.5 clients to start using the 'prod.triplea-game' server by modifying the lobby_games.yml file, which would then cause 2.5 clients to be redirect to the 2.6 lobby. Until then, this change has no impact.
Codecov Report
@@ Coverage Diff @@
## master #11191 +/- ##
=========================================
Coverage 27.21% 27.22%
Complexity 8250 8250
=========================================
Files 1217 1217
Lines 78074 78077 +3
Branches 10615 10615
=========================================
+ Hits 21251 21255 +4
+ Misses 54855 54854 -1
Partials 1968 1968
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update would have NGINX (which is listening on 'prod.triplea-game.org') send 2.5 game clients to the 2.6 lobby (2.5 is the current 'main' release).
The 2.6 lobby and 2.5 game clients are compatible with each other, so this is a safe configuration update to make.
Though, 2.5 clients are currently configured to use a 'prod2' URL and they would see no difference. But, we can configure the 2.5 clients to start using the 'prod.triplea-game' server by modifying the lobby_games.yml file, which would then cause 2.5 clients to be redirect to the 2.6 lobby. Until then, this change has no impact.
Change Summary & Additional Notes
Release Note