Dev Build: add servers to docker compose, automatically start services with gradlew run #12137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with gradlew run After this update, `./gradlew run` will automatically invoke composeUp to start all services. The locally running game client can then connect to the locally running lobby at "http://locahost" (port 80). This will send lobby login request to the locally running nginx which will then route the request to the lobby. This usage with nginx mirrors the production setup, and also simplifies localy configuration. Instead of having to configure the URL of every local service, we can configure that once in the nginx config and send all requests to the same 'locahost:80'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this update,
./gradlew runwill automatically invoke composeUp to start all services. The locally running game client can then connect to the locally running lobby at "http://locahost" (port 80).This will send lobby login request to the locally running nginx which will then route the request to the lobby. This usage with nginx mirrors the production setup, and also simplifies localy configuration. Instead of having to configure the URL of every local service, we can configure that once in the nginx config and send all requests to the same 'locahost:80'
Notes to Reviewer
Still need to update developer documentation. Planning to do that somewhat shortly - probably not as part of this PR, but soon 🤞