Image fix #12507
Merged
Image fix #12507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes to Reviewer
Fixes: #12500
Issue is difference between:
getImage(imageKey)vsgetTransformedImage(imageKey)getImagereturns a scaled image,getTransformedImagereturns an unscaled image.Issue was introduced in: 1ab27d4, there was a mistake to swap 'getTransformedImage' with 'getImage'. Without the clarification that one returns a scaled image and the other does not, it really does look they ought to return the same result. The multiple layers of caching also makes this confusing. It's very surprising for the 'image icon' cache to store unscaled images while the 'images' cache stores scaled images (one would expect both of them to store scaled images).
The problem with the purchase screen is that the scaled images were being used, rather than the 100% scale images.