Add unit option for when hit points damaged changes into

[ron-murhammer]

Addresses the first part of feature request: https://forums.triplea-game.org/topic/327/unit-option-when-damaged-change-into-different-unit-weakened-battleships

Functional Changes

• Added new unit option whenHitPointsDamagedChangesInto to allow units to change into a different unit type when damaged during battle

Tested

• Added the below example XML to TWW and tested running battles where battleships are damaged

Example XML

    <attachment name="unitAttachment" attachTo="germanBattleship" javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
      <option name="movement" value="2"/>
      <option name="attack" value="7"/>
      <option name="defense" value="8"/>
      <option name="canBombard" value="true"/>
      <option name="isSea" value="true"/>
      <option name="hitPoints" value="2"/>
      <option name="bombard" value="6"/>
      <option name="requiresUnits" value="germanDocks:germanFactory"/>
      <option name="consumesUnits" value="1:germanHull"/>
      <option name="whenHitPointsDamagedChangesInto" value="1:true:germanBattleshipDamaged"/>
    </attachment>
    <attachment name="unitAttachment" attachTo="germanBattleshipDamaged" javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
      <option name="movement" value="1"/>
      <option name="attack" value="3"/>
      <option name="defense" value="4"/>
      <option name="canBombard" value="true"/>
      <option name="isSea" value="true"/>
      <option name="hitPoints" value="2"/>
      <option name="bombard" value="3"/>
    </attachment>

[codecov-io]

Codecov Report

Merging #2689 into master will increase coverage by <.01%.
The diff coverage is 26.56%.

@@             Coverage Diff             @@
##             master   #2689      +/-   ##
===========================================
+ Coverage      20.2%   20.2%   +<.01%     
- Complexity     5759    5763       +4     
===========================================
  Files           816     816              
  Lines         73766   73813      +47     
  Branches      12312   12319       +7     
===========================================
+ Hits          14905   14916      +11     
- Misses        56725   56757      +32     
- Partials       2136    2140       +4

Impacted Files	Coverage Δ	Complexity Δ
...ames/strategy/triplea/delegate/BattleDelegate.java	23.07% <0%> (+0.09%)	53 <0> (ø)	⬇️
.../java/games/strategy/triplea/delegate/Matches.java	43.23% <0%> (-0.05%)	356 <1> (+1)
...mes/strategy/triplea/delegate/MustFightBattle.java	66.66% <41.66%> (-0.75%)	350 <3> (+1)
...s/strategy/triplea/attachments/UnitAttachment.java	42.48% <9.52%> (-0.43%)	325 <1> (+1)
src/main/java/games/strategy/net/nio/Decoder.java	67.3% <0%> (+0.96%)	25% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f781c8c...9b1e25f. Read the comment docs.

[ssoloff]

This method uses LinkedHashMap, but the field initializer uses HashMap. Was that intentional?

[ron-murhammer]

Fixed.

[ssoloff]

Do you need a similar null check in clearWhenHitPointsDamagedChangesInto() and setWhenHitPointsDamagedChangesInto(String)? Or will those code paths not be hit after deserializing an old save game?

[ron-murhammer]

Fairly sure those shouldn't be hit.