New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade license to GPL-3.0-or-later #2949
Upgrade license to GPL-3.0-or-later #2949
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
============================================
- Coverage 20.4% 20.39% -0.01%
+ Complexity 5770 5769 -1
============================================
Files 817 817
Lines 72905 72906 +1
Branches 12035 12035
============================================
- Hits 14876 14872 -4
- Misses 55933 55936 +3
- Partials 2096 2098 +2
Continue to review full report at Codecov.
|
README.md
Outdated
- Download and install TripleA: http://triplea-game.github.io/download/ | ||
# Installing TripleA and Playing | ||
|
||
- Download and install TripleA: http://www.triplea-game.org/download/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
www.triplea-game.org
should be just triplea-game.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe for this PR @veqryn @ron-murhammer and @DanVanAtta should all approve...
README.md
Outdated
|
||
Development | ||
=========== | ||
- Project documentation, including 'how to get started guides' at: https://github.com/triplea-game/triplea/tree/master/docs/dev | ||
- Broken map list: https://github.com/triplea-game/triplea/wiki/Broken-Maps | ||
- Additional feature request list: https://github.com/triplea-game/triplea/issues?q=label%3A%22ice+box+-+revisit+later%22+is%3Aclosed (list is not to be added to, if picked up, re-open and remove the ice-box label) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but the Ice Box label was renamed to ice box - close and revisit later
, so this link is broken.
Additionally this link should be hidden behind a nicer name, it really does not look good in the mark down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. In general, I don't like dropping bare URLs in Markdown, especially ones as busy as the ice box link. How about if I just hide all links in the README behind a label? For example:
Development
- Project documentation (including 'how to get started guides')
- Broken map list
- Additional feature request list (list is not to be added to, if picked up, re-open and remove the ice-box label)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 For consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the broken ice box link. I tested all the others; not sure why I skipped that one. 🤷
Also fix broken ice box issue link.
Confirmed. |
Per #2764.
Things of note:
Unrelated to #2764:
#
delimiters instead of underlining them with===
.www.triplea-game.org
instead oftriplea-game.github.io
), to use HTTPS if possible, etc.