New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for CompositeChange in case they have UnitHitsChange #3390

Merged

ron-murhammer merged 1 commit into master from Fix_BC_damagedChangesInto

Apr 22, 2018

Member

ron-murhammer commented Apr 21, 2018

Address issue reported here https://forums.triplea-game.org/topic/493/total-world-war-december-1941-beta-2-8-0-4/234

Essentially the battle calc wasn't processing the hit point deduction when having a damagedChangesInto unit.


          Add a check for CompositeChange in case they have UnitHitsChange

eca3fb5

Member Author

ron-murhammer commented Apr 22, 2018

Merging as minor change. Glad to address any comments in a follow on PR.

ron-murhammer merged commit 45cd464 into master

RoiEXLab deleted the Fix_BC_damagedChangesInto branch

April 22, 2018 06:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment