Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jpg and png file extensions for small map #3452

Merged
merged 2 commits into from Jun 9, 2018

Conversation

ron-murhammer
Copy link
Member

Address issue here: https://forums.triplea-game.org/topic/577/large-middle-earth-queries/112

Allow .jpg and .png file extensions in addition to .jpeg for small map images.

@codecov-io
Copy link

Codecov Report

Merging #3452 into master will decrease coverage by <.01%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3452      +/-   ##
============================================
- Coverage     21.99%   21.98%   -0.01%     
  Complexity     5915     5915              
============================================
  Files           832      832              
  Lines         71907    71912       +5     
  Branches      11584    11586       +2     
============================================
  Hits          15813    15813              
- Misses        54009    54014       +5     
  Partials       2085     2085
Impacted Files Coverage Δ Complexity Δ
...in/java/games/strategy/triplea/image/MapImage.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rc/main/java/games/strategy/triplea/Constants.java 100% <100%> (ø) 3 <1> (+1) ⬆️
.../src/main/java/games/strategy/net/nio/Decoder.java 72.82% <0%> (-1.09%) 24% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed0cd8...717f0ed. Read the comment docs.

@RoiEXLab RoiEXLab merged commit 4e8c9e1 into master Jun 9, 2018
@RoiEXLab RoiEXLab deleted the small_map_file_extensions branch June 9, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants