AI - place units on non infra factories

[ron-murhammer]

Overview

Addresses post: https://forums.triplea-game.org/topic/105/ai-development-discussion-and-feedback/110. AI only changes.

Functional Changes

Have the AI be able to use non-infra factories to place units.

Manual Testing Performed

• Tested 270BC (legions) and LAB posted here: https://forums.triplea-game.org/topic/105/ai-development-discussion-and-feedback/112
• Tested revised and global to ensure regular maps still function properly

[codecov-io]

Codecov Report

Merging #3645 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #3645      +/-   ##
============================================
- Coverage     22.55%   22.52%   -0.03%     
- Complexity     5983     6064      +81     
============================================
  Files           822      822              
  Lines         71032    72528    +1496     
  Branches      11479    11985     +506     
============================================
+ Hits          16019    16340     +321     
- Misses        52922    54076    +1154     
- Partials       2091     2112      +21

Impacted Files	Coverage Δ	Complexity Δ
...es/strategy/triplea/ai/pro/ProNonCombatMoveAi.java	0.21% <0%> (ø)	1 <0> (ø)	⬇️
...games/strategy/triplea/ai/pro/util/ProMatches.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...strategy/triplea/ai/pro/util/ProPurchaseUtils.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...tegy/triplea/ai/pro/data/ProPurchaseTerritory.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...a/games/strategy/triplea/ai/pro/ProPurchaseAi.java	0.32% <0%> (-0.01%)	1 <0> (ø)
...games/strategy/triplea/ai/pro/ProCombatMoveAi.java	0.35% <0%> (ø)	1 <0> (ø)	⬇️
...tegy/engine/message/unifiedmessenger/EndPoint.java	76.47% <0%> (-4.42%)	14% <0%> (-1%)
.../strategy/engine/data/BombingUnitDamageChange.java	66.66% <0%> (-2.57%)	7% <0%> (ø)
.../games/strategy/triplea/ui/screen/TileManager.java	3.69% <0%> (-0.37%)	12% <0%> (+4%)
...c/main/java/games/strategy/ui/SwingComponents.java	8.61% <0%> (-0.03%)	15% <0%> (+6%)
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e67003...6645fd0. Read the comment docs.

[ssoloff]

Just noting in case it wasn't your intention... this line is still calling the four-parameter version of findPurchaseOptionsForTerritory() where t == factoryTerritory. Assuming you thought you were going to add the fifth parameter here but changed your mind and left the reformatted line in place. Since the enclosing method is purchaseFactory(), I'm guessing that's a safe assumption. 😄

[ron-murhammer]

Yeah, that's exactly the case. I realized factoryOptions were only land territories so didn't need the fifth parameter.