Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display support type if game has multiple support types #3646

Merged

Conversation

ron-murhammer
Copy link
Member

Overview

Addresses post: https://forums.triplea-game.org/topic/942/unit-tooltip-improvements-poll/68

Functional Changes

Unit tooltip only displays support type if game has multiple support types (primarily used to avoid showing "ArtyOld" for simple maps).

Manual Testing Performed

  • Tested tooltips on 270BC and revised

@codecov-io
Copy link

Codecov Report

Merging #3646 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3646      +/-   ##
============================================
- Coverage     22.55%   22.55%   -0.01%     
- Complexity     5983     5984       +1     
============================================
  Files           822      822              
  Lines         71032    71033       +1     
  Branches      11479    11481       +2     
============================================
  Hits          16019    16019              
- Misses        52922    52924       +2     
+ Partials       2091     2090       -1
Impacted Files Coverage Δ Complexity Δ
...s/strategy/triplea/attachments/UnitAttachment.java 43.12% <0%> (-0.03%) 253 <0> (ø)
...tegy/engine/message/unifiedmessenger/EndPoint.java 76.47% <0%> (-4.42%) 14% <0%> (-1%)
.../strategy/triplea/odds/calculator/DummyPlayer.java 35.95% <0%> (+1.12%) 10% <0%> (+1%) ⬆️
...rategy/triplea/attachments/UnitTypeComparator.java 53.84% <0%> (+7.69%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e67003...67d88b5. Read the comment docs.

@ron-murhammer
Copy link
Member Author

Merging as minor unit tooltip change.

@ron-murhammer ron-murhammer merged commit a1af515 into master Jul 28, 2018
@DanVanAtta DanVanAtta deleted the Update_Unit_Tooltip_To_Check_For_Multiple_Support_Types branch July 30, 2018 17:43
@DanVanAtta
Copy link
Member

@ron-murhammer agree this is a minor update, but I think we should have let the standard review and merge process take hold here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants