Fix Land Scramble Error by preventing a route to/from the same territory

[ron-murhammer]

Overview

• Fixes Land Scramble Losing Starting Territory Causes Crash #4469

Functional Changes

• Add check to avoid a route from/to same territory which causes a crash

Manual Testing Performed

• Tested with this save game by scrambling UK fighters which then lose their starting territory:
  test.zip

[codecov-io]

Codecov Report

Merging #4494 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4494      +/-   ##
============================================
+ Coverage     22.96%   22.96%   +<.01%     
- Complexity     6209     6211       +2     
============================================
  Files           880      880              
  Lines         71236    71236              
  Branches      11335    11335              
============================================
+ Hits          16357    16360       +3     
+ Misses        52847    52846       -1     
+ Partials       2032     2030       -2

Impacted Files	Coverage Δ	Complexity Δ
...ames/strategy/triplea/delegate/BattleDelegate.java	24.42% <0%> (ø)	58 <0> (ø)	⬇️
.../strategy/triplea/odds/calculator/DummyPlayer.java	35.95% <0%> (+1.12%)	10% <0%> (+1%)	⬆️
...rategy/triplea/attachments/UnitTypeComparator.java	53.84% <0%> (+7.69%)	13% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea06d8...a63763d. Read the comment docs.

[RoiEXLab]

👍