Fix URL Endpoint #4705
Merged
Fix URL Endpoint #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitting this, but I think there may be confusion. Verifying that a JSON object has the same values is a manual test, hence the answer of 'none' is not correct. I wonder if the real confusion is what the point of the 'manual testing' column is for. Essentially it became too tiresome to hint that automated tests should be added, that manual testing notes would be added instead. It's a point of shame for things that should have been automated. |
|
@DanVanAtta I'd consider manual testing as running the engine once to ensure the correct behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a regression introduced in #3407 that came up during #3783
Functional Changes
Now every NodeBB username should work without editing
Manual Testing Performed
None. I verified the expected JSON is the same though.
/cc @panther2