Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strategic bombing land unit limitation #4804

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

ron-murhammer
Copy link
Member

Allow land units to perform strategic bombing. I did some basic testing and it seems to work fine. Just appears to be a unnecessary parsing check.

@codecov-io
Copy link

Codecov Report

Merging #4804 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4804      +/-   ##
============================================
- Coverage     23.21%   23.21%   -0.01%     
  Complexity     6150     6150              
============================================
  Files           860      860              
  Lines         69743    69743              
  Branches      11168    11168              
============================================
- Hits          16190    16189       -1     
  Misses        51528    51528              
- Partials       2025     2026       +1
Impacted Files Coverage Δ Complexity Δ
...s/strategy/triplea/attachments/UnitAttachment.java 43.33% <0%> (ø) 254 <0> (ø) ⬇️
...java/games/strategy/triplea/delegate/DiceRoll.java 64.42% <0%> (-0.32%) 139% <0%> (-1%)
.../src/main/java/games/strategy/net/nio/Decoder.java 66.07% <0%> (+1.78%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02e3b5...cbcff9d. Read the comment docs.

@RoiEXLab RoiEXLab merged commit 0769186 into master Apr 4, 2019
@RoiEXLab RoiEXLab deleted the Remove_Strategic_Bombing_Land_Unit_Limitation branch April 16, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants