Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception madness #5018

Merged
merged 3 commits into from Aug 20, 2019
Merged

Exception madness #5018

merged 3 commits into from Aug 20, 2019

Conversation

RoiEXLab
Copy link
Member

Overview

Read about https://forums.triplea-game.org/topic/1401/guests-joining-games-in-progress-crash-them/15
Hopefully this reduces the amount of thos false positive exceptions.

I believe I introduced this regression in #3447 and demonstrated how unchecked Exceptions cause bugs at a distance.

Functional Changes

Less pop-ups hopefully.

Manual Testing Performed

I verified no Exception dialog pops up when hosting locally when a user disconnects and a headless host doesn't actuall log an exception when a user disconnects

@codecov-io
Copy link

Codecov Report

Merging #5018 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5018      +/-   ##
============================================
- Coverage     23.95%   23.94%   -0.01%     
+ Complexity     6724     6722       -2     
============================================
  Files           998      998              
  Lines         77753    77764      +11     
  Branches      11625    11633       +8     
============================================
- Hits          18624    18621       -3     
- Misses        56984    56996      +12     
- Partials       2145     2147       +2
Impacted Files Coverage Δ Complexity Δ
...ine/message/unifiedmessenger/UnifiedMessenger.java 77.55% <ø> (ø) 27 <0> (ø) ⬇️
...ategy/engine/message/UnifiedInvocationHandler.java 80.95% <ø> (ø) 7 <0> (ø) ⬇️
...es/strategy/engine/message/MessengerException.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...ine/framework/startup/launcher/ServerLauncher.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...es/strategy/engine/player/DefaultPlayerBridge.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/games/strategy/engine/framework/ServerGame.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...trategy/engine/delegate/DefaultDelegateBridge.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/games/strategy/engine/GameOverException.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...tegy/engine/delegate/DelegateExecutionManager.java 25% <0%> (ø) 6 <0> (ø) ⬇️
...rategy/triplea/attachments/UnitTypeComparator.java 46.15% <0%> (-7.7%) 12% <0%> (-1%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1664874...e4fb840. Read the comment docs.

@ron-murhammer ron-murhammer merged commit 3b11eaf into triplea-game:master Aug 20, 2019
@RoiEXLab RoiEXLab deleted the exception-madness branch August 22, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants