Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ServerModel to return 'PlayerName' instead of String #5335

Merged
merged 1 commit into from Oct 11, 2019
Merged

Update ServerModel to return 'PlayerName' instead of String #5335

merged 1 commit into from Oct 11, 2019

Conversation

DanVanAtta
Copy link
Member

Refactor change to return strongly typed 'PlayerName' object
instead of a simple string.

Functional Changes

[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[x] Code Cleanup or refactor
[] Configuration Change
[] Bug fix:
[] Other:

Testing

[x] No manual testing done
[] Manually tested

Refactor change to return strongly typed 'PlayerName' object
instead of a simple string.
@codecov-io
Copy link

Codecov Report

Merging #5335 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5335   +/-   ##
=========================================
  Coverage     24.18%   24.18%           
  Complexity     6755     6755           
=========================================
  Files          1013     1013           
  Lines         77226    77226           
  Branches      11496    11496           
=========================================
  Hits          18674    18674           
  Misses        56419    56419           
  Partials       2133     2133
Impacted Files Coverage Δ Complexity Δ
...egy/engine/framework/startup/ui/ServerOptions.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/games/strategy/engine/framework/GameRunner.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ames/strategy/engine/lobby/client/LobbyClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ategy/engine/framework/startup/mc/ServerModel.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defd8c0...f79e4c5. Read the comment docs.

@DanVanAtta DanVanAtta merged commit 1010f72 into triplea-game:master Oct 11, 2019
@DanVanAtta DanVanAtta deleted the get-player-name branch October 11, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants