Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI fix v3 naval bombard #5531

Merged
merged 1 commit into from
Nov 19, 2019
Merged

AI fix v3 naval bombard #5531

merged 1 commit into from
Nov 19, 2019

Conversation

ron-murhammer
Copy link
Member

Fix comparison check to include equal to since strengthDifference can be infinity for v3 subs that have no defense. Otherwise the AI will never try to bombard with v3 transports if enemy ships are in range.

Copy link
Member

@DanVanAtta DanVanAtta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #5531 into master will increase coverage by 0.3%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #5531     +/-   ##
==========================================
+ Coverage      24.8%   25.1%   +0.3%     
- Complexity     7036    7197    +161     
==========================================
  Files          1064    1064             
  Lines         77705   78725   +1020     
  Branches      11516   12061    +545     
==========================================
+ Hits          19277   19767    +490     
- Misses        56241   56717    +476     
- Partials       2187    2241     +54
Impacted Files Coverage Δ Complexity Δ
...games/strategy/triplea/ai/pro/ProCombatMoveAi.java 0.3% <0%> (ø) 1 <0> (ø) ⬇️
...egy/triplea/ui/unit/scroller/UnitScrollerIcon.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/games/strategy/triplea/ui/ActionPanel.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...main/java/games/strategy/triplea/UrlConstants.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...trategy/triplea/ui/unit/scroller/UnitScroller.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...main/java/games/strategy/triplea/ui/MovePanel.java 0.84% <0%> (+0.09%) 4% <0%> (ø) ⬇️
...games/strategy/triplea/delegate/MoveValidator.java 58.71% <0%> (+5.45%) 296% <0%> (+61%) ⬆️
...rategy/triplea/delegate/AbstractPlaceDelegate.java 48.03% <0%> (+6.89%) 242% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7892b1...437a152. Read the comment docs.

@DanVanAtta DanVanAtta merged commit 99a6508 into master Nov 19, 2019
@DanVanAtta DanVanAtta deleted the AI_fix_v3_naval_bombard branch November 19, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants