Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Transports To Load Default #647

Merged
merged 10 commits into from
May 7, 2016
Merged

Improve Transports To Load Default #647

merged 10 commits into from
May 7, 2016

Commits on May 3, 2016

  1. Move transport methods from MoveValidator to TransportUtils

    @ron-murhammer
    ron-murhammer committed May 3, 2016
    Configuration menu
    Copy the full SHA
    0bdbeaa View commit details
    Browse the repository at this point in the history

Commits on May 4, 2016

  1. Clean up method comments

    @ron-murhammer
    ron-murhammer committed May 4, 2016
    Configuration menu
    Copy the full SHA
    30a6d2c View commit details
    Browse the repository at this point in the history

  2. Improve mapTransportsToLoad to try and fill as many units into as few 

    transports as possible
    @ron-murhammer
    ron-murhammer committed May 4, 2016
    Configuration menu
    Copy the full SHA
    e998519 View commit details
    Browse the repository at this point in the history

  3. Remove unused method

    @ron-murhammer
    ron-murhammer committed May 4, 2016
    Configuration menu
    Copy the full SHA
    6516b75 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2016

  1. Extract sorting code into helper methods

    @ron-murhammer
    ron-murhammer committed May 5, 2016
    Configuration menu
    Copy the full SHA
    76d0f91 View commit details
    Browse the repository at this point in the history

  2. Split mapTransportToLoad into 2 methods. One that focuses on finding the 

    min number of transports needed to load from the list. One that focuses
on distributing units evenly across the list of transports. The reason
this is needed is we want to optimize the default to the min but after
the user selects the number to load we want to put units in all of them.
    @ron-murhammer
    ron-murhammer committed May 5, 2016
    Configuration menu
    Copy the full SHA
    5723389 View commit details
    Browse the repository at this point in the history

  3. Update MovePanel to call the new MinTransports loading method to improve 

    the default number displayed to the user.
    @ron-murhammer
    ron-murhammer committed May 5, 2016
    Configuration menu
    Copy the full SHA
    be3d685 View commit details
    Browse the repository at this point in the history

  4. Organize methods

    @ron-murhammer
    ron-murhammer committed May 5, 2016
    Configuration menu
    Copy the full SHA
    f6339b3 View commit details
    Browse the repository at this point in the history

  5. Fix small typo

    @ron-murhammer
    ron-murhammer committed May 5, 2016
    Configuration menu
    Copy the full SHA
    93c0e5d View commit details
    Browse the repository at this point in the history

Commits on May 6, 2016

  1. Added helper method to improve readability

    @ron-murhammer
    ron-murhammer committed May 6, 2016
    Configuration menu
    Copy the full SHA
    a19dc84 View commit details
    Browse the repository at this point in the history