Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace console with log file #8436

Merged
merged 4 commits into from Dec 20, 2020
Merged

Conversation

DanVanAtta
Copy link
Member

@DanVanAtta DanVanAtta commented Dec 14, 2020

commit 74fc335

Add config to send log output to a file

commit b4b885d

Remove the debug console window

Proposed in forum post:
https://forums.triplea-game.org/topic/2497/replace-console-logging-with-a-file

commit 35533b2

Rename class 'DebugUtils' -> MemoryUsageReport

commit 52b9233

Move class 'MemoryUsageReport' to be near its usage

Testing

  • launched game, verified no issues selecting help menu and checking game settings

Screens Shots

Additional Notes to Reviewer

Release Note

UPDATE|Debug console has been replaced with a log file. The game will now generate a 'triplea.log' file with debug logging in it rather than having a console window to view it.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #8436 (52b9233) into master (a7a7576) will increase coverage by 0.03%.
The diff coverage is 40.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8436      +/-   ##
============================================
+ Coverage     24.83%   24.87%   +0.03%     
- Complexity     7304     7327      +23     
============================================
  Files          1265     1269       +4     
  Lines         79592    79253     -339     
  Branches      11085    11001      -84     
============================================
- Hits          19765    19712      -53     
+ Misses        57754    57484     -270     
+ Partials       2073     2057      -16     
Impacted Files Coverage Δ Complexity Δ
...trategy/engine/auto/update/EngineVersionCheck.java 50.00% <ø> (-1.73%) 8.00 <0.00> (-1.00)
...ava/games/strategy/engine/chat/ChatController.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...trategy/engine/chat/MessengersChatTransmitter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../strategy/engine/data/BombingUnitDamageChange.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/games/strategy/engine/data/UnitHitsChange.java 0.00% <ø> (-70.00%) 0.00 <0.00> (-6.00)
...tegy/engine/data/gameparser/ShallowGameParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...trategy/engine/delegate/DefaultDelegateBridge.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../games/strategy/engine/framework/AbstractGame.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/games/strategy/engine/framework/ClientGame.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/games/strategy/engine/framework/GameRunner.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15560ca...52b9233. Read the comment docs.

@DanVanAtta DanVanAtta merged commit b02d7da into master Dec 20, 2020
@DanVanAtta DanVanAtta deleted the replace-console-with-log-file branch December 20, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant