Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Locations from Google on iOS: Browser opens the Zip file in the Webview. #77

Closed
vitorpamplona opened this issue Mar 16, 2020 · 8 comments · Fixed by #410
Closed
Labels
Bug Something isn't working help wanted Extra attention is needed High Priority High importance / High value Work In Progress Don't merge quite yet, still in progress
Milestone

Comments

@vitorpamplona
Copy link
Collaborator

On Android, the app saves a file in the Downloads folder.

On iOS, the WebView shows the zipped binary file in the app itself.

We need to figure out a way to either download it to a file and then open with the SearchAndImport function or keep it in memory (500MB in memory?) and pass it to the SearchAndImport function.

@vitorpamplona vitorpamplona added the Bug Something isn't working label Mar 16, 2020
@1geek0
Copy link
Contributor

1geek0 commented Mar 19, 2020

How large can the location history file get?

@vitorpamplona
Copy link
Collaborator Author

My 7 years are 500MB :(

@1geek0
Copy link
Contributor

1geek0 commented Mar 19, 2020

Do we need that much? Can we add a date range to it?

@rparet rparet added this to Backlog in Private Kit Kanban Mar 19, 2020
@rparet rparet added For next release help wanted Extra attention is needed High Priority High importance / High value labels Mar 22, 2020
@rparet rparet added this to the v2.0 milestone Mar 22, 2020
@remintz
Copy link

remintz commented Mar 23, 2020

Just to illustrate what happens on IOS after downloading...
IMG_903E13968C76-1

popofibo pushed a commit to popofibo/private-kit that referenced this issue Apr 2, 2020
popofibo pushed a commit to popofibo/private-kit that referenced this issue Apr 2, 2020
popofibo pushed a commit to popofibo/private-kit that referenced this issue Apr 2, 2020
popofibo pushed a commit to popofibo/private-kit that referenced this issue Apr 2, 2020
@sergesemashko
Copy link
Contributor

#69 is related to this issue, also there is WIP PR #282 Change Import from webview to file picker that removes embedded webview for improved experience/privacy.

If it was up to me, I'd prefer to keep an approach from PR #282 that user has to login into google account rather from browser instead of webview and being able to select file from downloads folder.

So, this issue might no longer be relevant if the core and product team decides to favor the approach from #69 issue.

@popofibo
Copy link
Contributor

popofibo commented Apr 7, 2020

I kind of agree to replace webview with a file picker but unsure what is the timeline for that merge to happen. It's a cleaner approach no doubt but I personally did not get a chance to test it; this maybe a stopgap to alleviate the current broken iOS experience.

@tremblerz
Copy link
Contributor

I was working on #282 to fix, it still doesn't work but it would be great if someone is willing to lend a hand, it is a very high priority #282

@sergesemashko
Copy link
Contributor

sergesemashko commented Apr 10, 2020

By the way, the solution for large takeout files might be unzipping somewhere else and import only json files for the latest months manually into the app, e.g. 2020_APRIL.json. We can attach the instructions.

Under the hood, we can be checking the location timestamp freshness and let's say include only locations for the past 30 days.

@harshvitra harshvitra added the Work In Progress Don't merge quite yet, still in progress label Apr 14, 2020
Private Kit Kanban automation moved this from Backlog to Done Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working help wanted Extra attention is needed High Priority High importance / High value Work In Progress Don't merge quite yet, still in progress
Projects
No open projects
8 participants