-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Locations from Google on iOS: Browser opens the Zip file in the Webview. #77
Comments
How large can the location history file get? |
My 7 years are 500MB :( |
Do we need that much? Can we add a date range to it? |
#69 is related to this issue, also there is WIP PR #282 Change Import from webview to file picker that removes embedded webview for improved experience/privacy. If it was up to me, I'd prefer to keep an approach from PR #282 that user has to login into google account rather from browser instead of webview and being able to select file from downloads folder. So, this issue might no longer be relevant if the core and product team decides to favor the approach from #69 issue. |
I kind of agree to replace webview with a file picker but unsure what is the timeline for that merge to happen. It's a cleaner approach no doubt but I personally did not get a chance to test it; this maybe a stopgap to alleviate the current broken iOS experience. |
By the way, the solution for large takeout files might be unzipping somewhere else and import only json files for the latest months manually into the app, e.g. Under the hood, we can be checking the location timestamp freshness and let's say include only locations for the past 30 days. |
On Android, the app saves a file in the Downloads folder.
On iOS, the WebView shows the zipped binary file in the app itself.
We need to figure out a way to either download it to a file and then open with the SearchAndImport function or keep it in memory (500MB in memory?) and pass it to the SearchAndImport function.
The text was updated successfully, but these errors were encountered: