validate use case create gang

examples/json/create_gang.json

@@ -0,0 +1,6 @@
+{
+    "gang": {
+      "owner_id": "1",
+      "name": "The best gang"
+    }
+}

thesheriff/application/gang/request/create_gang_request.py

@@ -0,0 +1,12 @@
+class CreateGangRequest:
+    """Class JoinGangRequest holds data required to join a Gang.
+
+    :param name: Name of the Gang.
+    :type name: String
+    :param owner_id: Id of the Outlaw creating the gang.
+    :type owner_id: Integer
+    """
+
+    def __init__(self, owner_id: int, name: str):
+        self.owner_id = owner_id
+        self.name = name

thesheriff/application/outlaw/create_gang.py

@@ -1,4 +1,7 @@
 import inject
+
+from thesheriff.application.gang.request.create_gang_request import \
+    CreateGangRequest
 from thesheriff.domain.gang.gang_factory import GangFactory
 from thesheriff.domain.gang.repository.gang_repository import GangRepository
 from thesheriff.domain.gang.gang import Gang
@@ -15,7 +18,7 @@ class CreateGang:
     def __init__(self, gang_repository: GangRepository):
         self.__gang_repository = gang_repository
 
-    def execute(self, owner_id: int, name: str) -> Gang:
+    def execute(self, request: CreateGangRequest) -> Gang:
         """execute is the actual action of the Raid rating use case.
 
         :param owner_id: ID of the Outlaw creating the Gang.
@@ -25,6 +28,6 @@ def execute(self, owner_id: int, name: str) -> Gang:
         :return: The created Gang.
         :rtype: Gang
         """
-        gang = GangFactory.create(owner_id, name)
+        gang = GangFactory.create(request.owner_id, request.name)
         self.__gang_repository.add(gang)
         return gang

thesheriff/configuration.py

@@ -29,7 +29,9 @@
 
 gang_table = Table('gangs', METADATA,
                    Column('id', Integer, primary_key=True, autoincrement=True),
-                   Column('score', Integer, nullable=False),
+                   Column('score', Integer, nullable=False, default=0.0),
+                   Column('owner_id', Integer, nullable=False),
+                   Column('name', Text, nullable=False),
                    Column('members', ForeignKey('outlaws.id')))
 
 raid_table = Table('raids', METADATA,

thesheriff/domain/gang/gang.py

@@ -12,14 +12,12 @@ class Gang:
 
     def __init__(self, owner_id: int, name: str):
         # TODO(all)
-        # It would seem only logical that the owner is also a member.
-        # Should owner_id be an actual Outlaw instance?
+        # Verify owner_id is of an existing outlaw
         self.name = name
         self.members = list()
         self.created_raids = 0
         self.owner_id = owner_id
         self.id = None
-
         if self.name is None:
             raise Exception('Gang name required')
 
@@ -41,4 +39,5 @@ def add_members(self, members: list) -> NoReturn:
         """
         # TODO(all)
         # Should this be singular? add_member.
+        # It depends, if its a list, add_members is correct
         self.members = members

thesheriff/infrastructure/controllers/gang_controller.py

@@ -1,16 +1,19 @@
 import inject
 import json
-from flask import Blueprint, jsonify, Response, request
+from flask import Blueprint, jsonify, Response, request, make_response
+
+from thesheriff.application.gang.request.create_gang_request import \
+    CreateGangRequest
 from thesheriff.application.gang.request.join_gang_request import \
     JoinGangRequest
 from thesheriff.application.outlaw.join_gang import JoinGang
-from thesheriff.application.outlaw.create_gang import CreateGang
 from thesheriff.application.gang.list_gangs import ListGangs
+from thesheriff.application.outlaw.create_gang import CreateGang
 
 
 @inject.autoparams()
 def gang_controller(
-    join_gang: JoinGang, create_gang: CreateGang, list_gangs: ListGangs
+        join_gang: JoinGang, create_gang: CreateGang, list_gangs: ListGangs
 ) -> Blueprint:
     """gang_controller holds the blueprint for all gang routes.
 
@@ -104,16 +107,14 @@ def create_gang_endpoint() -> Response:
             return jsonify(message)
 
         data = request.json
+        new_gang = data.get('gang')
 
-        outlaw_id = data.get('owner_id')
-        name = data.get('name')
-
-        gang = create_gang.execute(outlaw_id, name)
+        gang_request = CreateGangRequest(new_gang.get('owner_id'),
+                                         new_gang.get('name'))
+        gang = create_gang.execute(gang_request)
 
-        gang_json = json.dumps(gang)
-
-        message = {'status': 201, 'gang': gang_json}
-
-        return jsonify(message)
+        gang_json = json.dumps(gang.__dict__)
+        resp = make_response(gang_json, 201)
+        return resp
 
     return blueprint_gang

thesheriff/infrastructure/controllers/outlaw_controller.py

@@ -8,6 +8,8 @@
 import json
 import inject
 from flask import Blueprint, jsonify, Response, request
+
+from thesheriff.application.outlaw import rate_raid
 from thesheriff.application.outlaw.create_outlaw import CreateOutlaw
 from thesheriff.application.outlaw.list_friends import ListFriends
 from thesheriff.application.outlaw.list_gangs import ListGangs
@@ -172,7 +174,7 @@ def invite_friend_blueprint(invite_friend: InviteFriend) -> Blueprint:
         :returns: Blueprint
         """
 
-    @invite_friend.route("/outlaw/invite_friend/", methods=['POST'])
+    @blueprint_outlaw.route("/outlaw/invite_friend/", methods=['POST'])
     def invite_friend(receiver_mail_address: str) -> Response:
         """Invite friend will receive a mail from a json payload and will send
         to him an invitation mail to join the app

thesheriff/infrastructure/repository/mysql_gang_repository.py

@@ -56,7 +56,8 @@ def add(self, new_gang: Gang) -> NoReturn:
         :return: No returned value.
         :rtype: NoReturn
         """
-        query = self.__gang_table.insert().value(**new_gang)
+        query = self.__gang_table.insert()\
+            .values(owner_id=new_gang.owner_id, name=new_gang.name)
         self.__connection.execute(query)
 
     def update(self, mod_gang: Gang) -> NoReturn: