Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Examples do not compile #31

Closed
Dzordzu opened this issue Sep 23, 2023 · 3 comments
Closed

[BUG] Examples do not compile #31

Dzordzu opened this issue Sep 23, 2023 · 3 comments

Comments

@Dzordzu
Copy link

Dzordzu commented Sep 23, 2023 •
edited
Loading

Problem

Self descriptive

Versions

Rust: 1.72
Piccolo: Both 0.1.0 and 0.1.1

Reasons

Iterpreter example

Changes in API. No reset method for Thread and more

Compiled example

The trait bounds are not satisfied
@Dzordzu Dzordzu changed the title [BUG] Interpreter example does not compile [BUG] Examples do not compile Sep 23, 2023
@kyren
Copy link
Owner

kyren commented Sep 23, 2023 •
edited
Loading

I believe that is because of the disconnect between the version in crates.io and the WIP version on github? The examples currently in the WIP version do compile when you compile from the github repository... it's even tested by CI I believe.

There will be a new crates.io release shortly anyway but this isn't a bug afaict?

@kyren
Copy link
Owner

kyren commented Sep 23, 2023

This is also partially my fault for not tagging the last release so that it would be easy to see that release in github. I'll close this when I release a new version on crates.io and properly tag it.

@Dzordzu
Copy link
Author

Dzordzu commented Sep 24, 2023

Great. Thanks a lot!

@kyren kyren closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyren @Dzordzu