Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for a new maintainer #11

Closed
luzpaz opened this issue Jan 21, 2022 · 17 comments
Closed

Looking for a new maintainer #11

luzpaz opened this issue Jan 21, 2022 · 17 comments

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Jan 21, 2022

FreeCAD/FreeCAD-addons#202

Or is the plan to adopt @realthunder's Link implementation of PieMenu?
RT are you planning to port it back to master?

@mdkus
Copy link

mdkus commented Jun 1, 2022

Hi luzpaz,
why isn't the PieMenu addon further developed? There doesn't seem to be actual pull requests. Is it because of realthunders integrated PieMenu?

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 1, 2022

Because no one has taken on the reigns to become the maintainer after @triplus left. And there is a whole host of backlogged issues that realthunder's is working on to get merged in to FreeCAD master branch (piemenu being a low priority on that list).

@mdkus
Copy link

mdkus commented Jun 1, 2022

Ok, I'm ready to do the job. What do I have to do as maintainer? How can I become maintainer?

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 1, 2022

Cool!

Next step: you can fork this repository and start hacking on changes.

@chennes, myself and others will vet some of the work and if all goes well we'll point the Addon Manager to your forked repo.

@mdkus
Copy link

mdkus commented Jun 2, 2022

Ok, I forked the repository. I'll take triplus' roadmap to v2.0 as guideline for contributions.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 2, 2022

You also may want to study @realthunder's PieMenu code on his branch? Have you used it before?

@mdkus
Copy link

mdkus commented Jun 3, 2022

Yes, I've tried it out. Looks great. I'll study the code and keep that in mind.

@mdkus
Copy link

mdkus commented Sep 12, 2022

Hi luzpaz,
Up to now I made 10 commits for a new version 1.1 of the pie menu. When do you plan to integrate the rep into the addon manager? By the way, can I become maintainer for triplus' glass module too?

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 12, 2022

@chennes care to weigh-in ?

@chennes
Copy link

chennes commented Sep 13, 2022

Well, obviously from my point of view I'd like to see a package.xml metadata file... perhaps one made with the new Addon Manager Developer Mode tools? 😁

@mdkus
Copy link

mdkus commented Sep 13, 2022

Ok, I'll prepare a package metafile und commit it.

@mdkus
Copy link

mdkus commented Sep 14, 2022

Ok, I'm ready for integration into addon manager. Here the latest commit of the necessary metafile.

@chennes
Copy link

chennes commented Sep 14, 2022

@luzpaz I think this looks good - make sure when you add it to the gitmodules file you note that the branch is "PieMenu2.0dev".

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 20, 2022

@mdkus can you change the name of the branch for uniformity sake (master or main) and also it's easier when I push changes to the FreeCAD-Addons repo ?

@mdkus
Copy link

mdkus commented Sep 21, 2022

Ok, I merged the branch with 'master' und set 'master' as 'default'. Then I deleted the branch 'PieMenu2.0dev'.

luzpaz added a commit to luzpaz/FreeCAD-addons that referenced this issue Sep 21, 2022
@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 21, 2022

Done. Congrats @mdkus and thank you for stepping up. There are still remaining open issues in this repo, can you address them ? I can close them once they've been vetted.

@luzpaz luzpaz closed this as completed Sep 21, 2022
@mdkus
Copy link

mdkus commented Sep 23, 2022

Yes, I'll vet the remaining open issues and address them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants