Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for URL #481

Merged
merged 1 commit into from Jul 28, 2018
Merged

Added validation for URL #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
335 changes: 170 additions & 165 deletions filemanager/upload.php
View file
Open in desktop
@@ -1,167 +1,172 @@
<?php
try{
if (!isset($config)){
$config = include 'config/config.php';
}

include 'include/utils.php';

if ($_SESSION['RF']["verify"] != "RESPONSIVEfilemanager")
{
response(trans('forbiden').AddErrorLocation(), 403)->send();
exit;
}

include 'include/mime_type_lib.php';


$ftp=ftp_con($config);
if($ftp){
$source_base = $config['ftp_base_folder'].$config['upload_dir'];
$thumb_base = $config['ftp_base_folder'].$config['ftp_thumbs_dir'];

}else{
$source_base = $config['current_path'];
$thumb_base = $config['thumbs_base_path'];
}
if(isset($_POST["fldr"])){
$_POST['fldr'] = str_replace('undefined','',$_POST['fldr']);
$storeFolder = $source_base.$_POST["fldr"];
$storeFolderThumb = $thumb_base.$_POST["fldr"];
}else{
return;
}

$fldr = rawurldecode(trim(strip_tags($_POST['fldr']),"/") ."/");

if (strpos($fldr,'../') !== FALSE
|| strpos($fldr,'./') !== FALSE
|| strpos($fldr,'..\\') !== FALSE
|| strpos($fldr,'.\\') !== FALSE )
{
response(trans('wrong path'.AddErrorLocation()))->send();
exit;
}

$path = $storeFolder;
$cycle = TRUE;
$max_cycles = 50;
$i = 0;
//GET config
while ($cycle && $i < $max_cycles)
{
$i++;
if ($path == $config['current_path']) $cycle = FALSE;
if (file_exists($path."config.php"))
{
$configTemp = include $path.'config.php';
$config = array_merge($config,$configTemp);
//TODO switch to array
$cycle = FALSE;
}
$path = fix_dirname($path).'/';
}

require('UploadHandler.php');
$messages = null;
if(trans("Upload_error_messages")!=="Upload_error_messages"){
$messages = trans("Upload_error_messages");
}

if(isset($_POST['url'])){
$temp = tempnam('/tmp','RF');
$ch = curl_init($_POST['url']);
$fp = fopen($temp, 'wb');
curl_setopt($ch, CURLOPT_FILE, $fp);
curl_setopt($ch, CURLOPT_HEADER, 0);
curl_exec($ch);
curl_close($ch);
fclose($fp);

$_FILES['files'] = array(
'name' => array(basename($_POST['url'])),
'tmp_name' => array($temp),
'size' => array(filesize($temp)),
'type' => null
);
}


if($config['mime_extension_rename']){
$info = pathinfo($_FILES['files']['name'][0]);
$mime_type = $_FILES['files']['type'][0];
if (function_exists('mime_content_type')){
$mime_type = mime_content_type($_FILES['files']['tmp_name'][0]);
}elseif(function_exists('finfo_open')){
$finfo = finfo_open(FILEINFO_MIME_TYPE);
$mime_type = finfo_file($finfo, $_FILES['files']['tmp_name'][0]);
}else{
include 'include/mime_type_lib.php';
$mime_type = get_file_mime_type($_FILES['files']['tmp_name'][0]);
}
$extension = get_extension_from_mime($mime_type);

if($extension=='so' || $extension=='' || $mime_type == "text/troff"){
$extension = $info['extension'];
}
$filename = $info['filename'].".".$extension;
}else{
$filename = $_FILES['files']['name'][0];
}
$_FILES['files']['name'][0] = fix_filename($filename,$config);


// LowerCase
if ($config['lower_case'])
{
$_FILES['files']['name'][0] = fix_strtolower($_FILES['files']['name'][0]);
}
if (!checkresultingsize($_FILES['files']['size'][0])) {
$upload_handler->response['files'][0]->error = sprintf(trans('max_size_reached'),$MaxSizeTotal).AddErrorLocation();
echo json_encode($upload_handler->response);
exit();
}

$uploadConfig = array(
'config' => $config,
'storeFolder' => $storeFolder,
'storeFolderThumb' => $storeFolderThumb,
'ftp' => $ftp,
'upload_dir'=> dirname($_SERVER['SCRIPT_FILENAME']).'/'.$storeFolder,
'upload_url' => $config['base_url'].$config['upload_dir'].$_POST['fldr'],
'mkdir_mode' => $config['folderPermission'],
'max_file_size' => $config['MaxSizeUpload']*1024*1024,
'correct_image_extensions' => true,
'print_response' => false
);
if(!$config['ext_blacklist']){
$uploadConfig['accept_file_types'] = '/\.('.implode('|',$config['ext']).')$/i';
}else{
$uploadConfig['accept_file_types'] = '/\.(?!('.implode('|',$config['ext_blacklist']).')$)/i';
}

if($ftp){
if (!is_dir($config['ftp_temp_folder'])) {
mkdir($config['ftp_temp_folder'], $config['folderPermission'], true);
}
if (!is_dir($config['ftp_temp_folder']."thumbs")) {
mkdir($config['ftp_temp_folder']."thumbs", $config['folderPermission'], true);
}
$uploadConfig['upload_dir'] = $config['ftp_temp_folder'];
}

$upload_handler = new UploadHandler($uploadConfig,true, $messages);

}catch(Exception $e){
$return = array();
foreach($_FILES['files']['name'] as $i => $name){
$return[] = array(
'name' => $name,
'error' => $e->getMessage(),
'size' => $_FILES['files']['size'][$i],
'type' => $_FILES['files']['type'][$i]
);
}
echo json_encode(array("files"=>$return));
}

try {
if (!isset($config)) {
$config = include 'config/config.php';
}

include 'include/utils.php';

if ($_SESSION['RF']["verify"] != "RESPONSIVEfilemanager") {
response(trans('forbiden') . AddErrorLocation(), 403)->send();
exit;
}

include 'include/mime_type_lib.php';

$ftp = ftp_con($config);

if ($ftp) {
$source_base = $config['ftp_base_folder'] . $config['upload_dir'];
$thumb_base = $config['ftp_base_folder'] . $config['ftp_thumbs_dir'];
} else {
$source_base = $config['current_path'];
$thumb_base = $config['thumbs_base_path'];
}

if (isset($_POST["fldr"])) {
$_POST['fldr'] = str_replace('undefined', '', $_POST['fldr']);
$storeFolder = $source_base . $_POST["fldr"];
$storeFolderThumb = $thumb_base . $_POST["fldr"];
} else {
return;
}

$fldr = rawurldecode(trim(strip_tags($_POST['fldr']), "/") . "/");

if (strpos($fldr, '../') !== false
|| strpos($fldr, './') !== false
|| strpos($fldr, '..\\') !== false
|| strpos($fldr, '.\\') !== false) {
response(trans('wrong path' . AddErrorLocation()))->send();
exit;
}

$path = $storeFolder;
$cycle = true;
$max_cycles = 50;
$i = 0;
//GET config
while ($cycle && $i < $max_cycles) {
$i++;
if ($path == $config['current_path']) {
$cycle = false;
}
if (file_exists($path . "config.php")) {
$configTemp = include $path . 'config.php';
$config = array_merge($config, $configTemp);
//TODO switch to array
$cycle = false;
}
$path = fix_dirname($path) . '/';
}

require('UploadHandler.php');
$messages = null;
if (trans("Upload_error_messages") !== "Upload_error_messages") {
$messages = trans("Upload_error_messages");
}

// make sure the length is limited to avoid DOS attacks
if (isset($_POST['url']) && strlen($_POST['url']) < 2000) {
$url = $_POST['url'];
$urlPattern = '/^(http|https):\/\/(([A-Z0-9][A-Z0-9_-]*)(\.[A-Z0-9][A-Z0-9_-]*)+)(?::\d{1,5})?(?:$|[?\/#])/i';

if (!preg_match($urlPattern, $url)) {
$temp = tempnam('/tmp', 'RF');

$ch = curl_init($url);
$fp = fopen($temp, 'wb');
curl_setopt($ch, CURLOPT_FILE, $fp);
curl_setopt($ch, CURLOPT_HEADER, 0);
curl_exec($ch);
curl_close($ch);
fclose($fp);

$_FILES['files'] = array(
'name' => array(basename($_POST['url'])),
'tmp_name' => array($temp),
'size' => array(filesize($temp)),
'type' => null
);
} else {
throw new Exception('Is not a valid URL.');
}
}


if ($config['mime_extension_rename']) {
$info = pathinfo($_FILES['files']['name'][0]);
$mime_type = $_FILES['files']['type'][0];
if (function_exists('mime_content_type')) {
$mime_type = mime_content_type($_FILES['files']['tmp_name'][0]);
} elseif (function_exists('finfo_open')) {
$finfo = finfo_open(FILEINFO_MIME_TYPE);
$mime_type = finfo_file($finfo, $_FILES['files']['tmp_name'][0]);
} else {
include 'include/mime_type_lib.php';
$mime_type = get_file_mime_type($_FILES['files']['tmp_name'][0]);
}
$extension = get_extension_from_mime($mime_type);

if ($extension == 'so' || $extension == '' || $mime_type == "text/troff") {
$extension = $info['extension'];
}
$filename = $info['filename'] . "." . $extension;
} else {
$filename = $_FILES['files']['name'][0];
}
$_FILES['files']['name'][0] = fix_filename($filename, $config);


// LowerCase
if ($config['lower_case']) {
$_FILES['files']['name'][0] = fix_strtolower($_FILES['files']['name'][0]);
}
if (!checkresultingsize($_FILES['files']['size'][0])) {
$upload_handler->response['files'][0]->error = sprintf(trans('max_size_reached'), $MaxSizeTotal) . AddErrorLocation();
echo json_encode($upload_handler->response);
exit();
}

$uploadConfig = array(
'config' => $config,
'storeFolder' => $storeFolder,
'storeFolderThumb' => $storeFolderThumb,
'ftp' => $ftp,
'upload_dir' => dirname($_SERVER['SCRIPT_FILENAME']) . '/' . $storeFolder,
'upload_url' => $config['base_url'] . $config['upload_dir'] . $_POST['fldr'],
'mkdir_mode' => $config['folderPermission'],
'max_file_size' => $config['MaxSizeUpload'] * 1024 * 1024,
'correct_image_extensions' => true,
'print_response' => false
);
if (!$config['ext_blacklist']) {
$uploadConfig['accept_file_types'] = '/\.(' . implode('|', $config['ext']) . ')$/i';
} else {
$uploadConfig['accept_file_types'] = '/\.(?!(' . implode('|', $config['ext_blacklist']) . ')$)/i';
}

if ($ftp) {
if (!is_dir($config['ftp_temp_folder'])) {
mkdir($config['ftp_temp_folder'], $config['folderPermission'], true);
}
if (!is_dir($config['ftp_temp_folder'] . "thumbs")) {
mkdir($config['ftp_temp_folder'] . "thumbs", $config['folderPermission'], true);
}
$uploadConfig['upload_dir'] = $config['ftp_temp_folder'];
}

$upload_handler = new UploadHandler($uploadConfig, true, $messages);
} catch (Exception $e) {
$return = array();
foreach ($_FILES['files']['name'] as $i => $name) {
$return[] = array(
'name' => $name,
'error' => $e->getMessage(),
'size' => $_FILES['files']['size'][$i],
'type' => $_FILES['files']['type'][$i]
);
}
echo json_encode(array("files" => $return));
}