Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate C9 validation error ignores #748

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Consolidate C9 validation error ignores #748

merged 2 commits into from
Sep 7, 2022

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Aug 29, 2022

Scope of changes

This fixes a compatibility issue with older VASP records. This problem manifests in an error on the Admin UI while trying to update a contact. In the contact update endpoint, GDS checks to make sure the entire VASP record including the contact is valid before committing the update and fails if it is not valid. This issue has been previously discussed in #34 and fixed in the TRISA codebase and we had to put a workaround in the GDS registration code.

This PR consolidates the workaround in one spot to avoid duplicated code and make sure that older VASPs that violate this constraint can still be edited from the Admin UI and adds a test to verify the current behavior.

SC-7632

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

This should fix SC-7632 and the admin should be able to edit contacts from the Admin dashboard.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@pdeziel pdeziel marked this pull request as ready for review August 30, 2022 19:23
Copy link
Collaborator

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pdeziel for streamlining these validation checks on VASPs to make sure we're doing things the same way everywhere!

@pdeziel pdeziel merged commit bce89ab into main Sep 7, 2022
@pdeziel pdeziel deleted the sc-7632 branch September 7, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants