[17.0][MIG] partner_address_two_lines: Migration to 17.0 #1

trisdoan · 2024-03-09T11:40:26Z

Changes in version 17.0

get_contact_name is removed. _compute_display_name is used instead of name_get due to this commit: Core: Remove name_get and use display_name instead odoo/odoo#122085
Introduce _get_complete_name

nguyenminhchien · 2024-03-11T10:00:24Z

partner_address_two_lines/models/res_partner.py



 class ResPartner(models.Model):
    _inherit = "res.partner"

-    def _get_contact_name(self, partner, name):
+    def _get_complete_name(self):


Traceback (most recent call last):
File "/home/chien/code/oca/partner-contact/17.0/partner_address_two_lines/tests/test_res_partner.py", line 35, in test_get_name
self.child_partner_name.display_name, "Test Company Name\nTest Partner Name"
File "/home/chien/code/odoo/odoo/17.0/odoo/fields.py", line 1206, in get
self.compute_value(recs)
File "/home/chien/code/odoo/odoo/17.0/odoo/fields.py", line 1388, in compute_value
records._compute_field_value(self)
File "/home/chien/code/odoo/odoo/17.0/odoo/models.py", line 4858, in _compute_field_value
fields.determine(field.compute, self)
File "/home/chien/code/odoo/odoo/17.0/odoo/fields.py", line 101, in determine
return needle(*args)
File "/home/chien/code/oca/partner-contact/17.0/partner_address_two_lines/models/res_partner.py", line 39, in _compute_display_name
name = rec._get_complete_name()
File "/home/chien/code/oca/partner-contact/17.0/partner_address_two_lines/models/res_partner.py", line 11, in _get_complete_name
res = super()._get_complete_name()
AttributeError: 'super' object has no attribute '_get_complete_name'

nguyenminhchien · 2024-03-11T10:01:40Z

partner_address_two_lines/models/res_partner.py

@@ -1,16 +1,40 @@
-# Copyright 2020 Camptocamp SA
+# Copyright 2024 Camptocamp SA


Don't change it

nguyenminhchien · 2024-03-12T02:36:10Z

partner_address_two_lines/models/res_partner.py

-                partner.commercial_company_name or partner.sudo().parent_id.name, name
-            )
+            splitted_names = res.split(", ")
+            return "\n".join([n for n in splitted_names if n.strip()])


it's quite risky when using res.split(", "). Imaging that i have:

commercial_company_name = TROBZ CO., LTD

name = Trí

res will be TROBZ CO., LTD, Trí. So, the result will be TROBZ CO.\nLTD\nTrí which's different from expected TROBZ CO., LTD\n Trí

nguyenminhchien · 2024-03-12T03:05:01Z

partner_address_two_lines/models/res_partner.py

+        if self.env.context.get("_two_lines_partner_address"):
+            for rec in self:
+                name = rec._get_complete_name()
+                rec.display_name = name.strip()


Suggestion:

if self.env.context.get("_two_lines_partner_address"): for rec in self: name = rec._get_complete_name() rec.display_name = name.strip() else: super()._compute_display_name()

nguyenminhchien · 2024-03-12T08:31:33Z

partner_address_two_lines/models/res_partner.py

+                name = f"{self.commercial_company_name or self.sudo().parent_id.name}\n{name}"  # noqa:E501
+            elif not self.is_company:
+                name = f"{self.commercial_company_name or self.sudo().parent_id.name}, {name}"  # noqa:E501
+        return name.strip()


You should call super() in this function. Otherwise, it could lead to the conflict with other modules.

nguyenminhchien · 2024-03-12T08:34:42Z

partner_address_two_lines/tests/test_res_partner.py

+        )
+
+        partner_2 = partner_model.create(
+            {"name": "TROBZ CO., LTD", "company_type": "company"}


I'm ok with this, but in the past, people from OCA requested to replace a real company name by a non-existed one.

nguyenminhchien · 2024-03-12T10:32:54Z

partner_address_two_lines/models/res_partner.py



 class ResPartner(models.Model):
    _inherit = "res.partner"

-    def _get_contact_name(self, partner, name):
+    def _get_complete_name(self):
+        res = super()._get_complete_name()
        if self.env.context.get("_two_lines_partner_address"):


Print the Quotation report (of sale.order), you can the Gemini Furniture and YourCompany were shown twice.
I checked v16 and saw that you should update this line to be: if (self.company_name or self.parent_id) and not self.is_company and self.env.context.get("_two_lines_partner_address"):

trisdoan · 2024-04-29T04:29:54Z

This change

Rename module, as agreed in [16.0] Replace partner_address_two_lines by partner_display_name_line_break OCA/partner-contact#1546
change logic of _compute_display_name: instead of recalculating display_name, find ', ' and replace it with line break. The previous approach did not take into account odoo native's contexts such as show_address
This PR does not depend on [FIX] base: Allow not showing address type if contact name is empty odoo/odoo#126451 as I agreed with NL66278, in here

Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_address_two_lines Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_address_two_lines/it/

nguyenminhchien · 2024-05-08T02:43:55Z

partner_display_name_line_break/models/res_partner.py

+                    pattern = r",\s(?=" + re.escape(name) + ")"
+                    partner.display_name = re.sub(pattern, "\n", partner.display_name)
+        else:
+            super()._compute_display_name()


super() has been called once at line 30

yeah silly me 🤣. Thanks a

nguyenminhchien · 2024-05-08T02:45:15Z

setup/partner_display_name_line_break/setup.py

@@ -0,0 +1,6 @@
+import setuptools


run pre-commit to remove the setup folder. or, remove it manually

trisdoan · 2024-05-08T07:32:09Z

Hi anh @nguyenminhchien, this PR is superseded by #2

trisdoan changed the title ~~[17.0][MIG] partner_address_two_lines~~ [17.0][MIG] partner_address_two_lines: Migration to 17.0 Mar 9, 2024

trisdoan force-pushed the 17.0-mig-partner_address_two_lines branch 2 times, most recently from 2203306 to 1889475 Compare March 10, 2024 04:40

nguyenminhchien suggested changes Mar 11, 2024

View reviewed changes

nguyenminhchien suggested changes Mar 12, 2024

View reviewed changes

trisdoan force-pushed the 17.0-mig-partner_address_two_lines branch from 1889475 to 7b4eb80 Compare March 12, 2024 07:43

trisdoan requested a review from nguyenminhchien March 12, 2024 07:44

nguyenminhchien suggested changes Mar 12, 2024

View reviewed changes

trisdoan force-pushed the 17.0-mig-partner_address_two_lines branch from 7b4eb80 to 8ee5bab Compare March 12, 2024 10:11

trisdoan requested a review from nguyenminhchien March 12, 2024 10:12

nguyenminhchien suggested changes Mar 12, 2024

View reviewed changes

trisdoan force-pushed the 17.0-mig-partner_address_two_lines branch from 8ee5bab to 319efba Compare March 12, 2024 10:57

nguyenminhchien approved these changes Mar 12, 2024

View reviewed changes

trisdoan closed this Mar 13, 2024

trisdoan reopened this Apr 29, 2024

trisdoan force-pushed the 17.0-mig-partner_address_two_lines branch 4 times, most recently from 28054d6 to 234aabf Compare May 1, 2024 10:15

Tonow-c2c and others added 10 commits May 2, 2024 15:15

[ADD][13.0] add partner_address_two_lines module

f5fda6a

[UPD] Update partner_address_two_lines.pot

8abe470

[UPD] README.rst

37393d5

[ADD] icon.png

d92d899

partner_address_two_lines 13.0.1.0.1

28e5035

[DCK] Pre-commit fixes

42bf4b3

partner_address_two_lines 13.0.1.0.2

8e7543d

[MIG] partner_address_two_lines: Migration to 16.0

77e09c6

[UPD] README.rst

a006631

Added translation using Weblate (Italian)

ee7fdee

mymage and others added 4 commits May 2, 2024 15:15

Replace partner_address_two_lines by partner_display_name_line_break

3c3e2a6

[IMP] partner_address_two_lines: precommit auto fixes

5e36dbd

[MIG] partner_address_two_lines: Migration to 17.0

38b03e3

trisdoan force-pushed the 17.0-mig-partner_address_two_lines branch from 234aabf to 38b03e3 Compare May 2, 2024 08:15

nguyenminhchien suggested changes May 8, 2024

View reviewed changes

trisdoan closed this May 8, 2024

trisdoan deleted the 17.0-mig-partner_address_two_lines branch May 24, 2024 04:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] partner_address_two_lines: Migration to 17.0 #1

[17.0][MIG] partner_address_two_lines: Migration to 17.0 #1

trisdoan commented Mar 9, 2024 •

edited

nguyenminhchien Mar 11, 2024

nguyenminhchien Mar 11, 2024

nguyenminhchien Mar 12, 2024

nguyenminhchien Mar 12, 2024

nguyenminhchien Mar 12, 2024

nguyenminhchien Mar 12, 2024

nguyenminhchien Mar 12, 2024

trisdoan commented Apr 29, 2024 •

edited

nguyenminhchien May 8, 2024

trisdoan May 8, 2024

nguyenminhchien May 8, 2024

trisdoan commented May 8, 2024

		@@ -1,16 +1,40 @@
		# Copyright 2020 Camptocamp SA
		# Copyright 2024 Camptocamp SA

[17.0][MIG] partner_address_two_lines: Migration to 17.0 #1

[17.0][MIG] partner_address_two_lines: Migration to 17.0 #1

Conversation

trisdoan commented Mar 9, 2024 • edited

Changes in version 17.0

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trisdoan commented Apr 29, 2024 • edited

This change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trisdoan commented May 8, 2024

trisdoan commented Mar 9, 2024 •

edited

trisdoan commented Apr 29, 2024 •

edited