ignore capture scopes for non consumed characters at yaml load time #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
force-pushed
the
ignore_captures_in_lookarounds
branch
from
f7f0ae5
to
42a0304
Compare
keith-hall
force-pushed
the
ignore_captures_in_lookarounds
branch
from
dd01103
to
44abffd
Compare
robinst
approved these changes
Oct 13, 2018
| @@ -588,6 +596,82 @@ impl<'a> RegexRewriter<'a> { | |||
| String::from_utf8(result).unwrap() | |||
| } | |||
|
|
|||
| fn get_consuming_capture_indexes(mut self) -> Vec<usize> { | |||
There was a problem hiding this comment.
Can you add some documentation here on what it does and why we need it? Basically what's in the PR description :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176 by re-purposing the regex re-writer to find capture groups which are not inside lookarounds. If, in a YAML syntax definition, a scope stack is applied to a capture group inside a lookaround, (i.e.
captures:\n x: scope.stack goes.herewherexis the number of a capture group in a lookahead/behind,)syntectwill now ignore it, just like Sublime Text does. Because it does this work at YAML load time, and not parse time, the parsing speed will not be affected (or, rather, it will be slightly improved/reduced for some syntax definitions by having less capture groups to apply operations for).