Add public method find_unlinked_contexts to SyntaxSet #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishume
approved these changes
Apr 21, 2021
|
Thanks, this feature makes sense and the implementation seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help ensure at asset/syntax set building time that all contexts which are push/set targets are resolvable, and no run-time errors should occur while parsing due to unlinked context references. Relates to: sharkdp/bat#915 (comment)
I wasn't sure the best way to present the results, so I'm just doing a debug formatting on any ContextReference which can't be found for now. Also, it may be useful in future to add some details about which context (i.e. the name given to the context) the match pattern with an invalid context reference was found in.