Objective-C compatibility #19
Conversation
felipowsky
commented
Jan 13, 2016
felipowsky
commented
- Objective-C compatibility
- Optional delegate functions
…viewcontroller extendedlayoutincludesopaquebars
|
It would be better to implement a protocol extension that has implementations of the delegate methods that don't do anything. That way you can override them if you want. Lets keep the @objc out of our Swift code. Unfortunately there isn't much you can do on the Enum. |
| @@ -56,6 +56,9 @@ public class HidingNavigationBarManager: NSObject, UIScrollViewDelegate, UIGestu | |||
| if viewController.navigationController == nil || viewController.navigationController?.navigationBar == nil { | |||
| fatalError("ViewController must be within a UINavigationController") | |||
| } | |||
|
|
|||
| viewController.extendedLayoutIncludesOpaqueBars = true | |||
There was a problem hiding this comment.
This is a separate issue from ObjC compatibility, and should be split into it's own PR/issue.
|
I agree with the comments @joshwalker made above. |
|
I've removed I think using Is there any reason for not using I will guess you don't want to limit Swift's capabilities with Objective-C compatibility and I understand. I just needed this for my Objective-C project. |
|
@felipowsky the reason I don't want to include |
