-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #25 Added ability to get the report filename #26
Conversation
Hello @BretMcDanel, Thanks for your PR, but I think the implementation is not taking care of all edge cases. A scan can be run on several URLs, generating several report files. I think the way to handle this usage of the Are you willing to implement such a change? |
Yeah, I can look at that. Off the cuff, an array of objects that contain at least:
Do you want anything else returned? It feels superfluous to include the report contents given they are saved to a file. Minimal parsing of the response could be done, for example counting issues (which would give a positive response that no issues were found, as opposed to no report being generated). Any other ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is good but just a couple of changes would be nice
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
I believe this will resolve everything. Thanks. |
I will apply some changes to this PR and merge it when I have a moment. Probably next week. |
When automating it may be advantageous to know with high certainty what the report filename is for further processing (eg XML -> anything).
This changes the local variable report_file_name to a class property report_file_name.
eg:
burp = Burpa( ... )
burp.scan( ... )
do_more_processing_on_report_file(burp.report_file_name)