Option to prefix date to messages #3
Conversation
| if(typeof colour === 'undefined') colour = noColour; | ||
|
|
||
| // add date as message prefix | ||
| var datePrefix = (options.datePrefix) ? (new Date()).toString() + ' ' : ''; |
There was a problem hiding this comment.
How do you feel about ISO8601via toISOString() ?
perhaps we can pass in a date format instead of just true? if the format is "ISO" or "ISO8601" it does it that way?
There was a problem hiding this comment.
I like the idea of letting users just put a boolean value to get a default or a string to get their desired format.
|
Thank you @brunomorency ! I'm happy to add it. I've added some inline comments for your consideration. |
|
Great, do you want me to make those changes or do you prefer putting it to your own tastes? |
|
I'll merge your stuff in and add what we agreed to. (I have to add to documentation, so might as well do it together). |
Option to prefix date to messages
|
@brunomorency all updated, committed, and published. If you have a chance, please take a look if I messed something up. Cheers! |
|
Changes made post-merge seem good to me, thanks for quickly accepting that pull request! |
Hi Tristan -- Here's a commit that adds an option to prefix date+time to all log messages. It's implemented through a logly.options() method that integrates both this 'date' option as well as the 'color' option added recently. To keep it backwards compatible, the logly.color() calls are still there but are just the same as logly.options({color: true}).